[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D2295: improve logging for kscreen
From:       sebas_(Sebastian_Kügler) <noreply () phabricator ! kde ! org>
Date:       2016-07-28 13:30:15
Message-ID: 20160728133014.17782.92404.CF8719C6 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


sebas added inline comments.

INLINE COMMENTS

> davidedmundson wrote in log.cpp:136
> why call instance() from inside a member function?
> it'll always return this.

Log::log(...) is static.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/log

REVISION DETAIL
  https://phabricator.kde.org/D2295

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, bshah, #plasma
Cc: davidedmundson, bshah, plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #5 (text/html)]

<table><tr><td style="">sebas added inline comments.</td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2295" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2295#inline-9206" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">log.cpp:136</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">why call instance() from inside a \
member function?<br /> it&#039;ll always return this.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Log::log(...) is static.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rLIBKSCREEN KScreen \
Library</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>sebas/log</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2295" \
rel="noreferrer">https://phabricator.kde.org/D2295</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>sebas, bshah, Plasma<br /><strong>Cc: \
</strong>davidedmundson, bshah, plasma-devel, ali-mohamed, jensreuterberg, abetts, \
sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]