'Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)
From:       Painless Roaster <painless.roaster () gmail ! com>
Date:       2016-07-27 16:38:58
Message-ID: 20160727163858.4620.51513 () mimi ! kde ! org
[Download RAW message or body]

--===============0962918866316957277==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote:
> > It seems to work fairly well, but the editor margins are not symmetric on the \
> > left and right with respect to the item delegate frame: 
> > ![Screenshot](http://i.imgur.com/2JhUtp4.png)
> 
> Painless Roaster wrote:
> It is OK. The vertical scroller is dynamically added if need. His addition \
> preserves text position and text wrapping. Therefore scroller is slightly to the \
> right. Try edit short text and add next characters until show scroller. You will \
> see that this is good. 
> Eike Hein wrote:
> It would be nicer if the overall editor would resize once the scrollbar appears so \
> the margins are still symmetric, avoiding the broken appearance in the screenshot. 
> Painless Roaster wrote:
> Thank you for your review. But horizontal center of editbox with scroller is not \
> good idea. My main idea is 'the same text position and wrap in label and edit box'. \
> If edit box show/hide vertical scroller, position of text must remain in place. \
> Movement with editbox is disturbing for user (if user inserted char for show \
> scroller or remove char for hide scroller).

Any news about use this patch to master branche?

- Painless

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128423/#review97371
-----------------------------------------------------------

On Čec. 13, 2016, 1:13 odp., Painless Roaster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128423/
> -----------------------------------------------------------
> 
> (Updated Čec. 13, 2016, 1:13 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=361097
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> fix rename file (or folder) in folder plugin (and desktop in folder mode)
> - enable multiline edit
> - fix size and position
> - fix escape from edit if user pressed Esc
> - fix suppress open file (or folder) if user clicked in editbox
> - fix size and position in popup mode
> 
> 
> Diffs
> -----
> 
> containments/desktop/package/contents/ui/FolderView.qml ced3507 
> 
> Diff: https://git.reviewboard.kde.org/r/128423/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Painless Roaster
> 
> 

--===============0962918866316957277==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128423/">https://git.reviewboard.kde.org/r/128423/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On červenec 14th, 2016, 7:58 dop. UTC, <b>Eike \
Hein</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It seems to work fairly well, but the editor margins \
are not symmetric on the left and right with respect to the item delegate frame:</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><img alt="Screenshot" \
src="http://i.imgur.com/2JhUtp4.png" style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>  \
</blockquote>

 <p>On červenec 14th, 2016, 9:44 dop. UTC, <b>Painless Roaster</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is \
OK. The vertical scroller is dynamically added if need. His addition preserves text \
position and text wrapping. Therefore scroller is slightly to the right. Try edit \
short text and add next characters until show scroller. You will see that this is \
good.</p></pre>  </blockquote>

 <p>On červenec 14th, 2016, 9:54 dop. UTC, <b>Eike Hein</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
would be nicer if the overall editor would resize once the scrollbar appears so the \
margins are still symmetric, avoiding the broken appearance in the \
screenshot.</p></pre>  </blockquote>

 <p>On červenec 14th, 2016, 2:40 odp. UTC, <b>Painless Roaster</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank \
you for your review. But horizontal center of editbox with scroller is not good idea. \
My main idea is 'the same text position and wrap in label and edit box'. If edit box \
show/hide vertical scroller, position of text must remain in place. Movement with \
editbox is disturbing for user (if user inserted char for show scroller or remove \
char for hide scroller).</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any \
news about use this patch to master branche?</p></pre> <br />

<p>- Painless</p>

<br />
<p>On červenec 13th, 2016, 1:13 odp. UTC, Painless Roaster wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Painless Roaster.</div>

<p style="color: grey;"><i>Updated Čec. 13, 2016, 1:13 odp.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=361097">https://bugs.kde.org/show_bug.cgi?id=361097</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">fix rename file (or folder) in folder plugin (and \
                desktop in folder mode)
 - enable multiline edit
 - fix size and position
 - fix escape from edit if user pressed Esc
 - fix suppress open file (or folder) if user clicked in editbox
 - fix size and position in popup mode</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>containments/desktop/package/contents/ui/FolderView.qml <span style="color: \
grey">(ced3507)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128423/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0962918866316957277==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 