[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-07-20 14:28:07
Message-ID: 20160720142805.87531.99567.EDE8D7B5 () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kwinqml.cpp:63
> + [this] (ShellSurfaceInterface *shellSurface) {
> + qDebug() << "Shell surface created";
> + m_surface = shellSurface->surface();
don't use qDebug, please use categorized logging.
> kwinqml.cpp:68
> + qDebug() << "Damage event recieved";
> + update();
> + }
ideally you don't need to repaint everything, but could just update the actual \
changed areas (carried in the damaged signal)
> kwinqml.cpp:106
> +{
> + if(!m_surface) {
> + return node;
please watch coding style
> kwinqml.cpp:112
> + n = new QSGSimpleTextureNode();
> + QSGTexture *texture = \
> window()->createTextureFromImage(m_surface->buffer()->data()); + \
> n->setTexture(texture);
you cannot just assume that there's a buffer attached to the surface. Please perform \
a nullptr check
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D1989
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
[Attachment #5 (text/html)]
<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added inline comments.<br />This revision now requires changes to proceed.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1989" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8836" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:63</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span class="p">[</span><span style="color: \
#aa4000">this</span><span class="p">]</span> <span class="p">(</span><span \
class="n">ShellSurfaceInterface</span> <span style="color: #aa2211">*</span><span \
class="n">shellSurface</span><span class="p">)</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> \
<span class="n">qDebug</span><span class="p">()</span> <span style="color: \
#aa2211"><<</span> <span style="color: #766510">"Shell surface \
created"</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="n">m_surface</span> \
<span style="color: #aa2211">=</span> <span class="n">shellSurface</span><span \
style="color: #aa2211">-></span><span class="n">surface</span><span \
class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">don't use qDebug, please use categorized logging.</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8839" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:68</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span class="n">qDebug</span><span \
class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: \
#766510">"Damage event recieved"</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">update</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">ideally you don't need to repaint everything, but could just \
update the actual changed areas (carried in the damaged signal)</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8837" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:106</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"><span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span><span \
class="p">(</span><span style="color: #aa2211">!</span><span \
class="n">m_surface</span><span class="p">)</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
style="color: #aa4000">return</span> <span class="n">node</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">please watch coding style</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8838" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:112</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span class="n">n</span> <span style="color: \
#aa2211">=</span> <span style="color: #aa4000">new</span> <span \
class="n">QSGSimpleTextureNode</span><span class="p">();</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">QSGTexture</span> <span style="color: #aa2211">*</span><span \
class="n">texture</span> <span style="color: #aa2211">=</span> <span \
class="n">window</span><span class="p">()</span><span style="color: \
#aa2211">-></span><span class="n">createTextureFromImage</span><span \
class="p">(</span><span class="n">m_surface</span><span style="color: \
#aa2211">-></span><span class="n">buffer</span><span class="p">()</span><span \
style="color: #aa2211">-></span><span class="n">data</span><span \
class="p">());</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;"> <span class="n">n</span><span style="color: \
#aa2211">-></span><span class="n">setTexture</span><span class="p">(</span><span \
class="n">texture</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you \
cannot just assume that there's a buffer attached to the surface. Please perform \
a nullptr check</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1989" \
rel="noreferrer">https://phabricator.kde.org/D1989</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>bdhruve, bshah, graesslin, Plasma on Wayland<br \
/><strong>Cc: </strong>bshah, graesslin, plasma-devel, kwin, hardening, \
jensreuterberg, abetts, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic