'Review Request 128392: [kickoff] kickoff should use icons from icon theme'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 128392: [kickoff] kickoff should use icons from icon theme
From:       Andrey Bondrov <andrey.bondrov () rosalab ! ru>
Date:       2016-07-07 17:12:14
Message-ID: 20160707171214.2360.17305 () mimi ! kde ! org
[Download RAW message or body]

--===============0077742849283819906==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128392/
-----------------------------------------------------------

Review request for Plasma and Eike Hein.

Bugs: 365204
    https://bugs.kde.org/show_bug.cgi?id=365204

Repository: plasma-desktop

Description
-------

Likely kickoff should use icons from icon theme, not from plasma theme. 

https://bugs.kde.org/show_bug.cgi?id=365204

Diffs
-----

  applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 

Diff: https://git.reviewboard.kde.org/r/128392/diff/

Testing
-------

1. Added kickoff applet to desktop
2. Swicthed from Breeze LAF to Oxygen
3. Rebooted
4. Kickoff got mixed Breeze and Oxygen icons (see screenshot in #365204)
5. Applied the patch
6. Rebooted
7. All Kickoff icons are properly set to Oxygen

Thanks,

Andrey Bondrov

--===============0077742849283819906==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128392/">https://git.reviewboard.kde.org/r/128392/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Eike Hein.</div>
<div>By Andrey Bondrov.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=365204">365204</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Likely kickoff should use icons from icon theme, not \
from plasma theme. </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: \
inherit;">https://bugs.kde.org/show_bug.cgi?id=365204</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Added kickoff applet to \
desktop</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Swicthed from Breeze LAF to Oxygen</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Rebooted</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Kickoff got mixed Breeze and Oxygen \
icons (see screenshot in #365204)</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Applied the patch</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Rebooted</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">All Kickoff icons are \
properly set to Oxygen</li> </ol></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/kickoff/package/contents/ui/KickoffButton.qml <span style="color: \
grey">(6b3a2b7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128392/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0077742849283819906==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 