[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-07-01 12:03:27
Message-ID: 20160701120326.41711.8007.63892085 () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision now requires changes to proceed.
I would like to see a test case which verifies that it starts the kwin_wayland \
instance and terminates it again.
INLINE COMMENTS
> kwinplugin.cpp:24-25
> +{
> + Q_ASSERT(uri == QLatin1String("org.kde.kwin.app"));
> + qmlRegisterType<KWinQml>(uri, 1, 0,"KWinApp");
> +}
Also here I dislike the name KWinApp and kwin.app - that's confusing due to kwinApp() \
already having a meaning.
> kwinqml.cpp:34-35
> +
> +KWinQml::KWinQml()
> +{
> +}
the call to the parent class is missing
> kwinqml.cpp:79-81
> + QStringList arguments;
> + arguments << "--xwayland";
> + kwinWayland->start(QStringLiteral(KWIN_INTERNAL_NAME_WAYLAND), arguments);
we also need to pass at least --socket with a useful name. Otherwise it cannot be \
started in a Wayland session.
> kwinqml.cpp:81
> + arguments << "--xwayland";
> + kwinWayland->start(QStringLiteral(KWIN_INTERNAL_NAME_WAYLAND), arguments);
> +}
how is this instance being terminated again?
> kwinqml.h:37
> + Q_OBJECT
> + Q_PROPERTY(QString socketName READ socketName WRITE setSocketName NOTIFY \
> socketNameChanged) +
please add documentation
> kwinqml.h:40
> +public:
> + KWinQml();
> + ~KWinQml() override;
QQuickItem *parent = nullptr
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D1989
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, bshah, #plasma_on_wayland, graesslin
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas
[Attachment #5 (text/html)]
<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added a reviewer: graesslin.<br />graesslin added a comment.<br />This revision now \
requires changes to proceed.</td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1989" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I would like to see a test case which \
verifies that it starts the kwin_wayland instance and terminates it \
again.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1989#inline-8002" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinplugin.cpp:24-25</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"><span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">Q_ASSERT</span><span class="p">(</span><span class="n">uri</span> <span \
style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span \
class="p">(</span><span style="color: \
#766510">"org.kde.kwin.app"</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">qmlRegisterType</span><span style="color: #aa2211"><</span><span \
class="n">KWinQml</span><span style="color: #aa2211">></span><span \
class="p">(</span><span class="n">uri</span><span class="p">,</span> <span \
style="color: #601200">1</span><span class="p">,</span> <span style="color: \
#601200">0</span><span class="p">,</span><span style="color: \
#766510">"KWinApp"</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Also here I dislike the name KWinApp and kwin.app - that's \
confusing due to kwinApp() already having a meaning.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8003" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:34-35</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"><span class="n">KWinQml</span><span style="color: \
#aa2211">::</span><span class="n">KWinQml</span><span class="p">()</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span \
class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the \
call to the parent class is missing</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8006" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:79-81</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span class="n">QStringList</span> <span \
class="n">arguments</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="n">arguments</span> <span \
style="color: #aa2211"><<</span> <span style="color: \
#766510">"--xwayland"</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">kwinWayland</span><span style="color: #aa2211">-></span><span \
class="n">start</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="n">KWIN_INTERNAL_NAME_WAYLAND</span><span class="p">),</span> <span \
class="n">arguments</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we \
also need to pass at least --socket with a useful name. Otherwise it cannot be \
started in a Wayland session.</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8007" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:81</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span class="n">arguments</span> <span style="color: \
#aa2211"><<</span> <span style="color: \
#766510">"--xwayland"</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">kwinWayland</span><span style="color: #aa2211">-></span><span \
class="n">start</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="n">KWIN_INTERNAL_NAME_WAYLAND</span><span class="p">),</span> <span \
class="n">arguments</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">how \
is this instance being terminated again?</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8005" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">kwinqml.h:37</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> \
<span class="n">Q_OBJECT</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span class="n">Q_PROPERTY</span><span \
class="p">(</span><span class="n">QString</span> <span class="n">socketName</span> \
<span class="n">READ</span> <span class="n">socketName</span> <span \
class="n">WRITE</span> <span class="n">setSocketName</span> <span \
class="n">NOTIFY</span> <span class="n">socketNameChanged</span><span \
class="p">)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">please add documentation</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-8004" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">kwinqml.h:40</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span \
style="color: #a0a000">public</span><span class="p">:</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">KWinQml</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa2211">~</span><span \
class="n">KWinQml</span><span class="p">()</span> <span \
class="n">override</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">QQuickItem *parent = nullptr</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1989" \
rel="noreferrer">https://phabricator.kde.org/D1989</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>bdhruve, bshah, Plasma on Wayland, graesslin<br \
/><strong>Cc: </strong>bshah, graesslin, plasma-devel, kwin, hardening, \
jensreuterberg, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic