[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland
From:       "bshah (Bhushan Shah)" <noreply () phabricator ! kde ! org>
Date:       2016-07-01 8:38:20
Message-ID: 20160701083819.31943.21418.7635F01F () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


bshah requested changes to this revision.
bshah added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwinqml.cpp:73-75
> +    QProcess *kwinWayland = new QProcess(this);
> +    kwinWayland->setProcessChannelMode(QProcess::ForwardedChannels);
> +    kwinWayland->start(QStringLiteral(KWIN_INTERNAL_NAME_WAYLAND));

Somehow seems you removed code for passing socket through WAYLAND_SOCKET environment \
variable and passing of --xwayland argument from this code. which was in previous \
revisions..

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas


[Attachment #5 (text/html)]

<table><tr><td style="">bshah requested changes to this revision.<br />bshah added \
inline comments.<br />This revision now requires changes to proceed.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1989" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-7992" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:73-75</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">    <span class="n">QProcess</span> <span style="color: \
#aa2211">*</span><span class="n">kwinWayland</span> <span style="color: \
#aa2211">=</span> <span style="color: #aa4000">new</span> <span \
class="n">QProcess</span><span class="p">(</span><span style="color: \
#aa4000">this</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">    <span class="n">kwinWayland</span><span \
style="color: #aa2211">-&gt;</span><span class="n">setProcessChannelMode</span><span \
class="p">(</span><span class="n">QProcess</span><span style="color: \
#aa2211">::</span><span class="n">ForwardedChannels</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span \
class="n">kwinWayland</span><span style="color: #aa2211">-&gt;</span><span \
class="n">start</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="n">KWIN_INTERNAL_NAME_WAYLAND</span><span class="p">));</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Somehow seems you removed code for passing socket through \
WAYLAND_SOCKET environment variable and passing of --xwayland argument from this \
code. which was in previous revisions..</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1989" \
rel="noreferrer">https://phabricator.kde.org/D1989</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>bdhruve, bshah, Plasma on Wayland<br /><strong>Cc: \
</strong>bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas<br \
/></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]