[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 16 lines] D2056: [Digital Clock] Hide agenda if no calendar event plugins a
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-06-30 21:17:52
Message-ID: differential-rev-PHID-DREV-cwjawkd4vxe57nuozjke-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, dvratil.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The agenda doesn't add a lot of usefulness if there aren't any appointments to be \
shown.  The weekday and date is also shown in the tooltip and I can see that people \
might prefer the older more compact look.  
  BUG: 364455
  FIXED-IN: 5.7.1

TEST PLAN
  Enabled holidays, got the agenda part
  Disabled holidays, agenda got hidden.
  Ensured that margins around look sane.
  
  Probably needs someone with a ton of appointments to look whether the margins \
between agenda and calendar are still ok when there's a scrollbar.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2056

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, dvratil
Cc: plasma-devel, jensreuterberg, sebas


[Attachment #5 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, Plasma: Design, dvratil.<br />broulik set the repository for this revision to \
rPLASMAWORKSPACE Plasma Workspace.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2056" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>The agenda doesn&#039;t add a lot of usefulness if there \
aren&#039;t any appointments to be shown.<br /> The weekday and date is also shown in \
the tooltip and I can see that people might prefer the older more compact look.</p>

<p>BUG: 364455<br />
FIXED-IN: 5.7.1</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Enabled \
holidays, got the agenda part<br /> Disabled holidays, agenda got hidden.<br />
Ensured that margins around look sane.</p>

<p>Probably needs someone with a ton of appointments to look whether the margins \
between agenda and calendar are still ok when there&#039;s a \
scrollbar.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2056" \
rel="noreferrer">https://phabricator.kde.org/D2056</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/digital-clock/package/contents/ui/CalendarView.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, Plasma: Design, dvratil<br /><strong>Cc: \
</strong>plasma-devel, jensreuterberg, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]