[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 4 lines] D2051: [Panel Containment] Fix containment size for right-to-left-
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-06-29 21:34:09
Message-ID: differential-rev-PHID-DREV-s7xqf2q5mrcz6c4w6fzo-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The X offset was already adjusted when in right-to-left mode, the width wasn't \
decreased by the same amound, however, pushing applets out the right side of the \
screen when widgets are locked.

TEST PLAN
  left-to-right, unlocked: works
  left-to-right, locked: works
  right-to-left, unlocked: works
  right-to-left, locked: works now, did not work before
  
  Also subtracting the Y value from the height to make the code look consistent

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2051

AFFECTED FILES
  containments/panel/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, jensreuterberg, sebas


[Attachment #5 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: \
Plasma.<br />broulik set the repository for this revision to rPLASMADESKTOP Plasma \
Desktop.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel.</td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2051" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The X \
offset was already adjusted when in right-to-left mode, the width wasn&#039;t \
decreased by the same amound, however, pushing applets out the right side of the \
screen when widgets are locked.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>left-to-right, unlocked: works<br /> left-to-right, locked: \
works<br /> right-to-left, unlocked: works<br />
right-to-left, locked: works now, did not work before</p>

<p>Also subtracting the Y value from the height to make the code look \
consistent</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2051" \
rel="noreferrer">https://phabricator.kde.org/D2051</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/panel/contents/ui/main.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
jensreuterberg, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]