[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Requested Changes To] D2047: [KDE Platform Theme] Set application layoutDirection ba
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-06-29 20:38:18
Message-ID: 20160629203816.90773.28220.1837EE80 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Looking at QGuiApplication.cpp this is all manner of wrong.
  
  You are right we have a bug, but this really isn't the fix:
  
  I'll take a look.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2047

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jensreuterberg, sebas

[Attachment #5 (text/html)]

<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added a reviewer: davidedmundson.<br />davidedmundson added a \
comment.<br />This revision now requires changes to proceed.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2047" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looking at \
QGuiApplication.cpp this is all manner of wrong.</p>

<p>You are right we have a bug, but this really isn&#039;t the fix:</p>

<p>I&#039;ll take a look.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAINTEGRATION Integration for Qt \
applications in Plasma</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D2047" \
rel="noreferrer">https://phabricator.kde.org/D2047</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma: Design, Plasma, davidedmundson<br \
/><strong>Cc: </strong>davidedmundson, plasma-devel, jensreuterberg, sebas<br \
/></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]