[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 3 lines] D2047: [KDE Platform Theme] Set application layoutDirection based 
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-06-29 20:27:55
Message-ID: differential-rev-PHID-DREV-pixnp3swinvsq46rerbx-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

[Attachment #4 (text/plain)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMAINTEGRATION Integration for Qt \
applications in Plasma. Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures that when starting the application with eg. Hebrew locale, the \
application is mirrored.  
  Qt does not seem to do this automatically but instead apparently wants you to \
include a QT_LAYOUT_DIRECTION string translated as either rtl or ltr in your app.

TEST PLAN
  LC_ALL=ar dolphin ← dolphin was reversed, before it was not
  LC_ALL=he dolphin ← dolphin was reversed, before it was not
  dolphin ← dolphin not reversed
  
  Not sure if this is the right approach though, or if there's a latent Qt bug.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2047

AFFECTED FILES
  src/platformtheme/kdeplatformtheme.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, jensreuterberg, sebas


[Attachment #5 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, Plasma: Design.<br />broulik set the repository for this revision to \
rPLASMAINTEGRATION Integration for Qt applications in Plasma.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2047" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
ensures that when starting the application with eg. Hebrew locale, the application is \
mirrored.</p>

<p>Qt does not seem to do this automatically but instead apparently wants you to \
include a QT_LAYOUT_DIRECTION string translated as either rtl or ltr in your \
app.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>LC_ALL=ar dolphin \
← dolphin was reversed, before it was not<br /> LC_ALL=he dolphin ← dolphin was \
reversed, before it was not<br /> dolphin ← dolphin not reversed</p>

<p>Not sure if this is the right approach though, or if there&#039;s a latent Qt \
bug.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAINTEGRATION Integration for Qt \
applications in Plasma</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D2047" \
rel="noreferrer">https://phabricator.kde.org/D2047</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/platformtheme/kdeplatformtheme.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, Plasma: Design<br /><strong>Cc: \
</strong>plasma-devel, jensreuterberg, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]