[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland
From: "bshah (Bhushan Shah)" <noreply () phabricator ! kde ! org>
Date: 2016-06-29 9:39:20
Message-ID: 20160629093919.3669.11350.220F106B () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
bshah added a comment.
Some minor issues I noticed..
INLINE COMMENTS
> CMakeLists.txt:13
> + Qt5::Quick
> + KF5::WaylandClient
> + KF5::WaylandServer
Not required, you just use WaylandServer API.
> kwinplugin.h:1
> +#ifndef KWINPLUGIN_H
> +#define KWINPLUGIN_H
This and all other header and C++ files are missing license headers,
See: https://community.kde.org/Policies/Licensing_Policy
> kwinqml.cpp:29-31
> + if (!m_socketName.isNull() && !m_socketName.isEmpty()) {
> + m_display->setSocketName(m_socketName);
> + }
Coding style.
> kwinqml.h:1
> +#include <QtQuick/QQuickItem>
> +#include <QObject>
You are missing include guard in this header file.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D1989
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas
[Attachment #5 (text/html)]
<table><tr><td style="">bshah added a comment.</td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1989" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Some minor issues I \
noticed..</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1989#inline-7907" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:13</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> Qt5::Quick </div><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> KF5::WaylandClient </div><div style="padding: 0 8px; margin: \
0 4px; background: #d0ffd0;"> KF5::WaylandServer </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not \
required, you just use WaylandServer API.</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-7906" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinplugin.h:1</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"><span style="color: #304a96">#ifndef KWINPLUGIN_H</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span \
style="color: #304a96">#define KWINPLUGIN_H</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
and all other header and C++ files are missing license headers,</p>
<p style="padding: 0; margin: 8px;">See: <a \
href="https://community.kde.org/Policies/Licensing_Policy" class="remarkup-link" \
target="_blank" rel="noreferrer">https://community.kde.org/Policies/Licensing_Policy</a></p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-7908" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kwinqml.cpp:29-31</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #aa2211">!</span><span \
class="n">m_socketName</span><span class="p">.</span><span \
class="n">isNull</span><span class="p">()</span> <span style="color: \
#aa2211">&&</span> <span style="color: #aa2211">!</span><span \
class="n">m_socketName</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">m_display</span><span style="color: #aa2211">-></span><span \
class="n">setSocketName</span><span class="p">(</span><span \
class="n">m_socketName</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Coding style.</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1989#inline-7905" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">kwinqml.h:1</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span \
style="color: #304a96">#include <QtQuick/QQuickItem></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: \
#304a96">#include <QObject></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
are missing include guard in this header file.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1989" \
rel="noreferrer">https://phabricator.kde.org/D1989</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>bdhruve, Plasma on Wayland<br /><strong>Cc: \
</strong>bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas<br \
/></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic