[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126356: change minimum size of clipboard
From: Andreas Kainz <kainz.a () gmail ! com>
Date: 2016-06-10 22:40:04
Message-ID: 20160610224004.6392.2941 () mimi ! kde ! org
[Download RAW message or body]
--===============1035730662198926646==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/
-----------------------------------------------------------
(Updated Juni 10, 2016, 10:40 nachm.)
Status
------
This change has been discarded.
Review request for Plasma and Heiko Tietze.
Repository: plasma-workspace
Description
-------
if you use clipboard on the desktop the minimum window height is heigher than you use \
clipboard from the panel (drop down window). As the user can define the width and \
height for the desktop plasmoid the minimum allowed height should be at least the \
same than the drop down window in the panel. so I change the minimumHeig to 16.
Diffs
-----
applets/clipboard/contents/ui/clipboard.qml 97230c1
Diff: https://git.reviewboard.kde.org/r/126356/diff/
Testing
-------
File Attachments
----------------
old before with 26 min height
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
new after with 16 min height
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png
screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/566b420b-df44-44d4-86b3-b9f2d441aed8__clipboardMinimumSize.png
Thanks,
Andreas Kainz
--===============1035730662198926646==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126356/">https://git.reviewboard.kde.org/r/126356/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Heiko Tietze.</div>
<div>By Andreas Kainz.</div>
<p style="color: grey;"><i>Updated Juni 10, 2016, 10:40 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">if you use clipboard on the desktop the minimum window \
height is heigher than you use clipboard from the panel (drop down window). As the \
user can define the width and height for the desktop plasmoid the minimum allowed \
height should be at least the same than the drop down window in the panel. so I \
change the minimumHeig to 16.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/clipboard/contents/ui/clipboard.qml <span style="color: \
grey">(97230c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126356/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png">old \
before with 26 min height</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png">new \
after with 16 min height</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/566b420b-df44-44d4-86b3-b9f2d441aed8__clipboardMinimumSize.png">screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1035730662198926646==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic