[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Requested Changes To] D1771: [Workspace Options] Add option to disable OSD
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-06-06 5:47:37
Message-ID: 20160606054735.36472.17987.2981B42B () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> mainpage.ui:60
> + <property name="text">
> + <string>Visual feedback for keyboard shortcuts:</string>
> + </property>
The OSD will also be triggered for things like "disable touch pad when external mouse \
gets connected". So that wording seems wrong to me.
> workspaceoptions.cpp:55
> connect(m_ui->showToolTips, SIGNAL(toggled(bool)), this, SLOT(changed()));
> + connect(m_ui->showOsd, SIGNAL(toggled(bool)), this, SLOT(changed()));
> }
new connect syntax? (yes I am aware that changed is both a slot and a signal here and \
needs to be casted)
> workspaceoptions.cpp:66
> {
> + KConfig config(QStringLiteral("plasmarc"));
> +
KSharedConfig::openConfig
> workspaceoptions.cpp:75
> + KConfigGroup cg(&config, QStringLiteral("OSD"));
> + cg.writeEntry("Enabled", m_ui->showOsd->isChecked());
> + }
for the readEntry you use QStringLiteral
> workspaceoptions.cpp:90
> + {
> + KConfigGroup cg(&config, QStringLiteral("OSD"));
> + m_ui->showOsd->setChecked(cg.readEntry(QStringLiteral("Enabled"), true));
QStringLiteral("OSD") is used twice in this file. Make it const static
> workspaceoptions.cpp:90
> + {
> + KConfigGroup cg(&config, QStringLiteral("OSD"));
> + m_ui->showOsd->setChecked(cg.readEntry(QStringLiteral("Enabled"), true));
as you only read from the cg you can make it const
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1771
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma:_design, #plasma, graesslin
Cc: graesslin, plasma-devel, sebas
[Attachment #5 (text/html)]
<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added a reviewer: graesslin.<br />graesslin added inline comments.<br />This revision \
now requires changes to proceed.</td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1771" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1771#inline-6934" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mainpage.ui:60</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <property name="text"> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> \
<string>Visual feedback for keyboard shortcuts:</string> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> </property> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">The OSD will also be triggered for things like "disable touch pad \
when external mouse gets connected". So that wording seems wrong to \
me.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1771#inline-6936" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">workspaceoptions.cpp:55</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span><span \
class="n">m_ui</span><span style="color: #aa2211">-></span><span \
class="n">showToolTips</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span class="n">toggled</span><span \
class="p">(</span><span style="color: #aa4000">bool</span><span class="p">)),</span> \
<span style="color: #aa4000">this</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span class="n">changed</span><span \
class="p">()));</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;"> <span class="n">connect</span><span class="p">(</span><span \
class="n">m_ui</span><span style="color: #aa2211">-></span><span \
class="n">showOsd</span><span class="p">,</span> <span class="n">SIGNAL</span><span \
class="p">(</span><span class="n">toggled</span><span class="p">(</span><span \
style="color: #aa4000">bool</span><span class="p">)),</span> <span style="color: \
#aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">changed</span><span class="p">()));</span> \
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">new connect syntax? (yes I am aware that changed is both a slot and a \
signal here and needs to be casted)</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1771#inline-6935" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">workspaceoptions.cpp:66</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "><span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: #d0ffd0;"> <span class="n">KConfig</span> <span \
class="n">config</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"plasmarc"</span><span class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">KSharedConfig::openConfig</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1771#inline-6939" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">workspaceoptions.cpp:75</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="n">KConfigGroup</span> \
<span class="n">cg</span><span class="p">(</span><span style="color: \
#aa2211">&</span><span class="n">config</span><span class="p">,</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"OSD"</span><span class="p">));</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">cg</span><span \
class="p">.</span><span class="n">writeEntry</span><span class="p">(</span><span \
style="color: #766510">"Enabled"</span><span class="p">,</span> <span \
class="n">m_ui</span><span style="color: #aa2211">-></span><span \
class="n">showOsd</span><span style="color: #aa2211">-></span><span \
class="n">isChecked</span><span class="p">());</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">for the readEntry you use QStringLiteral</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1771#inline-6937" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">workspaceoptions.cpp:90</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">KConfigGroup</span> <span class="n">cg</span><span class="p">(</span><span \
style="color: #aa2211">&</span><span class="n">config</span><span \
class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">"OSD"</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">m_ui</span><span style="color: #aa2211">-></span><span \
class="n">showOsd</span><span style="color: #aa2211">-></span><span \
class="n">setChecked</span><span class="p">(</span><span class="n">cg</span><span \
class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"Enabled"</span><span class="p">),</span> <span style="color: \
#304a96">true</span><span class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">QStringLiteral("OSD") is used twice in this file. Make it const \
static</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1771#inline-6938" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">workspaceoptions.cpp:90</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">KConfigGroup</span> <span class="n">cg</span><span class="p">(</span><span \
style="color: #aa2211">&</span><span class="n">config</span><span \
class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">"OSD"</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">m_ui</span><span style="color: #aa2211">-></span><span \
class="n">showOsd</span><span style="color: #aa2211">-></span><span \
class="n">setChecked</span><span class="p">(</span><span class="n">cg</span><span \
class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"Enabled"</span><span class="p">),</span> <span style="color: \
#304a96">true</span><span class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">as \
you only read from the cg you can make it const</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1771" \
rel="noreferrer">https://phabricator.kde.org/D1771</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma: Design, Plasma, graesslin<br \
/><strong>Cc: </strong>graesslin, plasma-devel, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic