[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Requested Changes To] D1730: address race condition around setoperation
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-06-01 14:51:32
Message-ID: 20160601145118.80086.73877.E8BE2ED6 () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> daemon.cpp:190
> {
> + qCDebug(KSCREEN_KDED) << "QET" << m_changeBlockTimer->isValid() << \
> m_changeBlockTimer->hasExpired(100) << m_changeBlockTimer->elapsed(); + if \
> (m_changeBlockTimer->isValid() && !m_changeBlockTimer->hasExpired(100)) {
never call elapsed on a not valid timer! The behavior is undefined.
> daemon.cpp:195
> + return;
> + }
> qCDebug(KSCREEN_KDED) << "Change detected";
I suggest to do the invalidate as I suggested as it frees up resources.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D1730
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
[Attachment #5 (text/html)]
<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added inline comments.<br />This revision now requires changes to proceed.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1730" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1730#inline-6811" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">daemon.cpp:190</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;"> <span class="n">qCDebug</span><span class="p">(</span><span \
class="n">KSCREEN_KDED</span><span class="p">)</span> <span style="color: \
#aa2211"><<</span> <span style="color: #766510">"QET"</span> <span \
style="color: #aa2211"><<</span> <span class="n">m_changeBlockTimer</span><span \
style="color: #aa2211">-></span><span class="n">isValid</span><span \
class="p">()</span> <span style="color: #aa2211"><<</span> <span \
class="n">m_changeBlockTimer</span><span style="color: #aa2211">-></span><span \
class="n">hasExpired</span><span class="p">(</span><span style="color: \
#601200">100</span><span class="p">)</span> <span style="color: \
#aa2211"><<</span> <span class="n">m_changeBlockTimer</span><span style="color: \
#aa2211">-></span><span class="n">elapsed</span><span class="p">();</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">m_changeBlockTimer</span><span style="color: #aa2211">-></span><span \
class="n">isValid</span><span class="p">()</span> <span style="color: \
#aa2211">&&</span> <span style="color: #aa2211">!</span><span \
class="n">m_changeBlockTimer</span><span style="color: #aa2211">-></span><span \
class="n">hasExpired</span><span class="p">(</span><span style="color: \
#601200">100</span><span class="p">))</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">never call elapsed on a not valid timer! The behavior is \
undefined.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1730#inline-6812" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">daemon.cpp:195</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">return</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;"> <span class="p">}</span> </div><div style="padding: 0 8px; margin: 0 \
4px; "> <span class="n">qCDebug</span><span class="p">(</span><span \
class="n">KSCREEN_KDED</span><span class="p">)</span> <span style="color: \
#aa2211"><<</span> <span style="color: #766510">"Change \
detected"</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
suggest to do the invalidate as I suggested as it frees up \
resources.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKSCREEN KScreen</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1730" \
rel="noreferrer">https://phabricator.kde.org/D1730</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>sebas, graesslin<br /><strong>Cc: </strong>plasma-devel, \
Plasma, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic