[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D1722: Import next-gen libtaskmanager.
From: "hein (Eike Hein)" <noreply () phabricator ! kde ! org>
Date: 2016-05-31 9:44:13
Message-ID: 20160531094412.17831.93898.1D88C46C () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Messages.sh:3
> The legacy version is also called this.
>
> That will cause a breakage on the i18n side.
>
> Either:
> two .pot files
> OR
> one Messages.sh
I'll pick option 3: Remove Messages.sh :-)
The new lib doesn't contain any strings, that the Messages.sh is there is an \
oversight. Thanks for catching!
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1722
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, Plasma
Cc: davidedmundson, plasma-devel, sebas
[Attachment #5 (text/html)]
<div>hein added inline comments.</div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1722#inline-6597" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> \
wrote in <span style="color: #4b4d51; font-weight: bold;">Messages.sh:3</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">The legacy version is also called this.</p>
<p style="padding: 0; margin: 8px;">That will cause a breakage on the i18n side.</p>
<p style="padding: 0; margin: 8px;">Either: <br />
two .pot files<br />
OR<br />
one Messages.sh</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">I'll pick option 3: Remove Messages.sh :-)</p>
<p style="padding: 0; margin: 8px;">The new lib doesn't contain any strings, \
that the Messages.sh is there is an oversight. Thanks for \
catching!</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1722" \
rel="noreferrer">https://phabricator.kde.org/D1722</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic