From kde-panel-devel  Tue May 31 09:32:44 2016
From: =?utf-8?q?graesslin_=28Martin_Gr=C3=A4=C3=9Flin=29?= <noreply () phabricator ! kde ! or
Date: Tue, 31 May 2016 09:32:44 +0000
To: kde-panel-devel
Subject: [Differential] [Requested Changes To] D1672: Add support for touch events in fakeinput protocol and 
Message-Id: <20160531093244.2373.46394.FF2704A1 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146468717801209
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============6097464899114268624=="

--===============6097464899114268624==
Content-Type: multipart/alternative; boundary="b7b807eeb31d4fa7a7b568743a2a4bd1"

--b7b807eeb31d4fa7a7b568743a2a4bd1
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  Looks good, but please fix the coding style.

INLINE COMMENTS

> fakeinput_interface.cpp:201-202
> +    }
> +    if(touchIds.contains(id))
> +    {
> +        return;

please watch coding style - same in all other areas you just adjusted.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, Plasma
Cc: bshah, graesslin, plasma-devel, sebas

--b7b807eeb31d4fa7a7b568743a2a4bd1
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<div>graesslin=20requested=20changes=20to=20this=20revision.<br=20/>
graesslin=20added=20a=20comment.<br=20/>
This=20revision=20now=20requires=20changes=20to=20proceed.</div><br=20/><di=
v><div><p>Looks=20good,=20but=20please=20fix=20the=20coding=20style.</p></d=
iv></div><br=20/><div><strong>INLINE=20COMMENTS</strong><div><div=20style=
=3D"margin:=206px=200=2012px=200;"><div=20style=3D"border:=201px=20solid=20=
#C7CCD9;=20border-radius:=203px;"><div=20style=3D"padding:=200;=20backgroun=
d:=20#F7F7F7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20border-=
width:=200=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=
=20background:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=
=20style=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https://p=
habricator.kde.org/D1672#inline-6603"=20rel=3D"noreferrer">View=20Inline</a=
><span=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">fakeinput_inter=
face.cpp:201-202</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#d0ffd0;">=20=20=20=20<span=20=
class=3D"p">}</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20style=3D"color:=20#aa4000">if</span><span=
=20class=3D"p">(</span><span=20class=3D"n">touchIds</span><span=20class=3D"=
p">.</span><span=20class=3D"n">contains</span><span=20class=3D"p">(</span><=
span=20class=3D"n">id</span><span=20class=3D"p">))</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20class=3D"p">{</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20<span=20style=3D"color:=20#aa4000">re=
turn</span><span=20class=3D"p">;</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">please=20watch=20coding=20style=20-=20same=20=
in=20all=20other=20areas=20you=20just=20adjusted.</p></div></div></div></di=
v></div><br=20/><div><strong>REPOSITORY</strong><div><div>rKWAYLAND=20KWayl=
and</div></div></div><br=20/><div><strong>REVISION=20DETAIL</strong><div><a=
=20href=3D"https://phabricator.kde.org/D1672"=20rel=3D"noreferrer">https://=
phabricator.kde.org/D1672</a></div></div><br=20/><div><strong>EMAIL=20PREFE=
RENCES</strong><div><a=20href=3D"https://phabricator.kde.org/settings/panel=
/emailpreferences/"=20rel=3D"noreferrer">https://phabricator.kde.org/settin=
gs/panel/emailpreferences/</a></div></div><br=20/><div><strong>To:=20</stro=
ng>bdhruve,=20bshah,=20graesslin,=20Plasma<br=20/><strong>Cc:=20</strong>bs=
hah,=20graesslin,=20plasma-devel,=20sebas<br=20/></div>
--b7b807eeb31d4fa7a7b568743a2a4bd1--

--===============6097464899114268624==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl
dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo=

--===============6097464899114268624==--