[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-05-30 5:58:29
Message-ID: 20160530055829.13759.7998.615B509E () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
graesslin added inline comments.
INLINE COMMENTS
> xuetianweng wrote in main_wayland.cpp:449
> Don't do this. Otherwise qtvirtualkeyboard will be the only usable input method for Qt.
>
> IMHO for wayland there should be a wayland specific im module that talk to input method via wl_text.
>
> And X11 app should use a different QT_IM_MODULE.
>
> FYI: https://fcitx-im.org/wiki/Input_method_related_environment_variables
> Don't do this. Otherwise qtvirtualkeyboard will be the only usable input method for Qt.
That's totally fine in this case. It only affects KWin and KWin doesn't have any text input fields.
> IMHO for wayland there should be a wayland specific im module that talk to input method via wl_text.
QtWayland uses wl_text by default if QT_IM_MODULE is not specified. I think that's exactly what you want.
> And X11 app should use a different QT_IM_MODULE.
Look at the file name, it's main_wayland.cpp ;-) Doesn't affect X11 at all.
REPOSITORY
rKWIN KWin
BRANCH
virtual-keyboard
REVISION DETAIL
https://phabricator.kde.org/D1638
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
[Attachment #5 (text/html)]
<div>graesslin added inline comments.</div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1638#inline-6500" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">xuetianweng</span> wrote \
in <span style="color: #4b4d51; font-weight: bold;">main_wayland.cpp:449</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">Don't do this. Otherwise qtvirtualkeyboard will be the only usable \
input method for Qt.</p>
<p style="padding: 0; margin: 8px;">IMHO for wayland there should be a wayland \
specific im module that talk to input method via wl_text.</p>
<p style="padding: 0; margin: 8px;">And X11 app should use a different \
QT_IM_MODULE.</p>
<p style="padding: 0; margin: 8px;">FYI: <a \
href="https://fcitx-im.org/wiki/Input_method_related_environment_variables" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://fcitx-im.org/wiki/Input_method_related_environment_variables</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px \
solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px \
12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">Don't do \
this. Otherwise qtvirtualkeyboard will be the only usable input method for \
Qt.</p></blockquote>
<p style="padding: 0; margin: 8px;">That's totally fine in this case. It only \
affects KWin and KWin doesn't have any text input fields.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p \
style="padding: 0; margin: 8px;">IMHO for wayland there should be a wayland specific \
im module that talk to input method via wl_text.</p></blockquote>
<p style="padding: 0; margin: 8px;">QtWayland uses wl_text by default if QT_IM_MODULE \
is not specified. I think that's exactly what you want.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p \
style="padding: 0; margin: 8px;">And X11 app should use a different \
QT_IM_MODULE.</p></blockquote>
<p style="padding: 0; margin: 8px;">Look at the file name, it's main_wayland.cpp \
;-) Doesn't affect X11 at all.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>virtual-keyboard</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1638" \
rel="noreferrer">https://phabricator.kde.org/D1638</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, Plasma, sebas<br /><strong>Cc: \
</strong>xuetianweng, sebas, mart, broulik, plasma-devel<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic