'Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in grou'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in grou
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2016-05-29 3:55:52
Message-ID: 20160529035552.24948.13056 () mimi ! kde ! org
[Download RAW message or body]

--===============4456681103991663561==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Май 28, 2016, 10:35 след обяд, Eike Hein wrote:
> > The description is insufficient. If it works, why is this necessary? What \
> > differences does it make? What is it trying to achieve?
> 
> Anthony Fieroni wrote:
> Activate works because of kwin, closing not works. It is correct to me, that code \
> to present. So if you don't want it, i can revert code on activate window. On close \
> window must stay. 
> Eike Hein wrote:
> Why should closing a window cancel the highlight effect?

By clicking on close button in tooltip:
1. associated window is closing
2. tooltip is dismissed
So effect must be stopped or you must continue to work in the middle of effect.

- Anthony

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/#review95957
-----------------------------------------------------------

On Май 28, 2016, 10:19 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128038/
> -----------------------------------------------------------
> 
> (Updated Май 28, 2016, 10:19 след обяд)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> 1. Enable highlighted window, tooltips and grouping
> 2. Open more then one in goup
> 3. Close one of grouped windows by click at tooltip button
> 
> 
> Diffs
> -----
> 
> applets/taskmanager/plugin/backend.cpp afc6b91c0f492565b76a0a01e042ca7acbdbc0b4 
> 
> Diff: https://git.reviewboard.kde.org/r/128038/diff/
> 
> 
> Testing
> -------
> 
> Activate window "works" because kwin stops effect on activate, however it better to \
> be stopped. 
> 
> Thanks,
> 
> Anthony Fieroni
> 
> 

--===============4456681103991663561==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128038/">https://git.reviewboard.kde.org/r/128038/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> On Май 28th, 2016, 10:35 след обяд \
EEST, Eike Hein wrote: <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;">The description is insufficient. If it \
works, why is this necessary? What differences does it make? What is it trying to \
achieve?</pre> </blockquote>

On Май 28th, 2016, 11:13 след обяд EEST, Anthony Fieroni \
wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Activate works because of kwin, closing not works. It is correct to me, \
that code to present. So if you don't want it, i can revert code on activate window. \
On close window must stay.</pre> </blockquote>

 <p>On Май 29th, 2016, 12:29 преди обяд EEST, <b>Eike Hein</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
should closing a window cancel the highlight effect?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By \
clicking on close button in tooltip: 1. associated window is closing
2. tooltip is dismissed
So effect must be stopped or you must continue to work in the middle of \
effect.</p></pre> <br />

<p>- Anthony</p>

<br />
<p>On Май 28th, 2016, 10:19 след обяд EEST, Anthony Fieroni wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Eike Hein.</div>
<div>By Anthony Fieroni.</div>

<p style="color: grey;"><i>Updated Май 28, 2016, 10:19 след обяд</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Enable highlighted \
window, tooltips and grouping</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Open more then one in \
goup</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Close one of grouped windows by click at tooltip \
button</li> </ol></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Activate window "works" because kwin stops effect on \
activate, however it better to be stopped.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/plugin/backend.cpp <span style="color: \
grey">(afc6b91c0f492565b76a0a01e042ca7acbdbc0b4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128038/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4456681103991663561==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 