[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interfac
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-05-25 13:41:37
Message-ID: 20160525134133.71192.85961.3DDD8EFB () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


graesslin added a comment.


  In https://phabricator.kde.org/D1672#31094, @bshah wrote:
  
  > In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
  >
  > > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id \
1 doesn't make sense if we never got a touchDown for id 1. This would require \
tracking the used ids in FakeInputInterface. But it must be done somewhere - either \
in the library or by the user of the library.  >
  >
  > IMO client ideally will not send bogus event. And in any case if it does, \
compositor itself should ignore bogus events because it is the one which is \
processing in end..  
  
  a client could also use this to attack (crash) the Compositor by sending bogus \
events. That's security relevant from my point of view.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, graesslin, Plasma, bshah
Cc: bshah, graesslin, plasma-devel, sebas


[Attachment #5 (text/html)]

<div>graesslin added a comment.</div><br /><div><div><blockquote style="border-left: \
3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D1672#31094" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D1672#31094</a>, <a \
href="https://phabricator.kde.org/p/bshah/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@bshah</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D1672#31046" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D1672#31046</a>, <a \
href="https://phabricator.kde.org/p/graesslin/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I&#039;m wondering: should we ensure that \
the ids are correct. E.g. a touchUp for id 1 doesn&#039;t make sense if we never got \
a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. \
But it must be done somewhere - either in the library or by the user of the \
library.</p></div> </blockquote>

<p>IMO client ideally will not send bogus event. And in any case if it does, \
compositor itself should ignore bogus events because it is the one which is \
processing in end..</p></div> </blockquote>

<p>a client could also use this to attack (crash) the Compositor by sending bogus \
events. That&#039;s security relevant from my point of view.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWAYLAND KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1672" \
rel="noreferrer">https://phabricator.kde.org/D1672</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>bdhruve, graesslin, Plasma, bshah<br /><strong>Cc: \
</strong>bshah, graesslin, plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]