[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interfac
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-05-25 12:08:17
Message-ID: 20160525120809.71172.26459.44D93530 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


graesslin added a comment.


  I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 \
doesn't make sense if we never got a touchDown for id 1. This would require tracking \
the used ids in FakeInputInterface. But it must be done somewhere - either in the \
library or by the user of the library.

INLINE COMMENTS

> fakeinput_interface.cpp:196
> +    FakeInputDevice *d = device(resource);
> +    if (!d || !d->isAuthenticated()) {
> +        return;

The isAuthenticated check is not verified in the autotest. That's the same with the \
other new methods.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, graesslin, Plasma, bshah
Cc: bshah, graesslin, plasma-devel, sebas


[Attachment #5 (text/html)]

<div>graesslin added a comment.</div><br /><div><div><p>I&#039;m wondering: should we \
ensure that the ids are correct. E.g. a touchUp for id 1 doesn&#039;t make sense if \
we never got a touchDown for id 1. This would require tracking the used ids in \
FakeInputInterface. But it must be done somewhere - either in the library or by the \
user of the library.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1672#inline-6450" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">fakeinput_interface.cpp:196</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">    <span class="n">FakeInputDevice</span> <span \
style="color: #aa2211">*</span><span class="n">d</span> <span style="color: \
#aa2211">=</span> <span class="n">device</span><span class="p">(</span><span \
class="n">resource</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #aa2211">!</span><span class="n">d</span> <span \
style="color: #aa2211">||</span> <span style="color: #aa2211">!</span><span \
class="n">d</span><span style="color: #aa2211">-&gt;</span><span \
class="n">isAuthenticated</span><span class="p">())</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span \
style="color: #aa4000">return</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The \
isAuthenticated check is not verified in the autotest. That&#039;s the same with the \
other new methods.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWAYLAND KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1672" \
rel="noreferrer">https://phabricator.kde.org/D1672</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>bdhruve, graesslin, Plasma, bshah<br /><strong>Cc: \
</strong>bshah, graesslin, plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]