[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package
From: Marco Martin <notmart () gmail ! com>
Date: 2016-05-03 8:40:54
Message-ID: 20160503084054.6730.78610 () mimi ! kde ! org
[Download RAW message or body]
--===============7414901419597159268==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127702/#review95128
-----------------------------------------------------------
autotests/configmodeltest.cpp (line 26)
<https://git.reviewboard.kde.org/r/127702/#comment64562>
could it be added another test on another (fake) applet that has the full \
main.xml and config.qml infrastructure to check keys are created correctly?
- Marco Martin
On May 3, 2016, 7:04 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127702/
> -----------------------------------------------------------
>
> (Updated May 3, 2016, 7:04 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The source \
> property will be empty for KCM pages. This fixes correctly returning empty source \
> for KCM pages. Also return the same value from get().
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 747e8e0
> autotests/configmodeltest.h PRE-CREATION
> autotests/configmodeltest.cpp PRE-CREATION
> autotests/data/testpackage/metadata.desktop 2a28849
> src/plasmaquick/configmodel.cpp 3f69073
>
> Diff: https://git.reviewboard.kde.org/r/127702/diff/
>
>
> Testing
> -------
>
> Added qml config page to plasma-pa, KCM page now works fine.
>
>
> Thanks,
>
> David Rosca
>
>
--===============7414901419597159268==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127702/">https://git.reviewboard.kde.org/r/127702/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127702/diff/3/?file=464046#file464046line26" \
style="color: black; font-weight: bold; text-decoration: \
underline;">autotests/configmodeltest.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">26</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">ConfigModelTest</span><span \
class="o">::</span><span class="n">emptySourceWithApplet</span><span \
class="p">()</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">could \
it be added another test on another (fake) applet that has the full main.xml and \
config.qml infrastructure to check keys are created correctly?</p></pre> </div>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On May 3rd, 2016, 7:04 a.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated May 3, 2016, 7:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ConfigModel may contain ConfigCategory for both QML \
pages and KCM pages. The source property will be empty for KCM pages. This fixes \
correctly returning empty source for KCM pages. Also return the same value from \
get().</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added qml config page to plasma-pa, KCM page now works \
fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(747e8e0)</span></li>
<li>autotests/configmodeltest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/configmodeltest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/data/testpackage/metadata.desktop <span style="color: \
grey">(2a28849)</span></li>
<li>src/plasmaquick/configmodel.cpp <span style="color: grey">(3f69073)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127702/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7414901419597159268==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic