'Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2016-05-03 0:20:54
Message-ID: 20160503002054.17946.94425 () mimi ! kde ! org
[Download RAW message or body]

--===============5077335723314337458==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127734/
-----------------------------------------------------------

(Updated May 3, 2016, 12:20 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit e8c5a28df28d2d66e8eaee47550425941e3e7ade by Martin Klapetek to \
branch master.

Repository: plasma-workspace

Description
-------

Brings back the agenda to the calendar that was
redone in September.

Once this is in, I'll push the review 125862 and
that should be all to get holidays back to the 
calendar.

Diffs
-----

  applets/digital-clock/package/contents/config/config.qml 877e40c 
  applets/digital-clock/package/contents/config/main.xml aacbe27 
  applets/digital-clock/package/contents/ui/CalendarView.qml 381bddb 
  applets/digital-clock/package/contents/ui/configAppearance.qml fc9a09e 
  applets/digital-clock/package/contents/ui/configCalendar.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127734/diff/

Testing
-------

See the screenshot with kholidays plugin backend.

File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/24/67ed5b51-acb2-46b8-8e1e-db87f0692903__snapshot113.png

Thanks,

Martin Klapetek

--===============5077335723314337458==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127734/">https://git.reviewboard.kde.org/r/127734/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated May 3, 2016, 12:20 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit e8c5a28df28d2d66e8eaee47550425941e3e7ade by Martin \
Klapetek to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Brings back the agenda to the calendar that was redone \
in September.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Once this is in, I'll push the review 125862 and that \
should be all to get holidays back to the  calendar.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See the screenshot with kholidays plugin \
backend.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/digital-clock/package/contents/config/config.qml <span style="color: \
grey">(877e40c)</span></li>

 <li>applets/digital-clock/package/contents/config/main.xml <span style="color: \
grey">(aacbe27)</span></li>

 <li>applets/digital-clock/package/contents/ui/CalendarView.qml <span style="color: \
grey">(381bddb)</span></li>

 <li>applets/digital-clock/package/contents/ui/configAppearance.qml <span \
style="color: grey">(fc9a09e)</span></li>

 <li>applets/digital-clock/package/contents/ui/configCalendar.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127734/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/24/67ed5b51-acb2-46b8-8e1e-db87f0692903__snapshot113.png">Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5077335723314337458==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 