From kde-panel-devel Sat Apr 30 23:00:46 2016 From: Kai Uwe Broulik Date: Sat, 30 Apr 2016 23:00:46 +0000 To: kde-panel-devel Subject: Review Request 127802: [Converter Runner] Try QLocale::toDouble to get input value Message-Id: <20160430230046.11646.69099 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146205726422866 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7276558145713158540==" --===============7276558145713158540== Content-Type: multipart/alternative; boundary="===============2033511988857000614==" --===============2033511988857000614== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127802/ ----------------------------------------------------------- Review request for Plasma. Repository: kdeplasma-addons Description ------- Only if that fails, it tries QString::toDouble and if even that fails it skips. This allows the user to enter numbers in a more natural way. Diffs ----- runners/converter/converterrunner.cpp d9cffc3 Diff: https://git.reviewboard.kde.org/r/127802/diff/ Testing ------- I can now convert "5,5ft" (comma being the decimal indicator in German) or "1.524m" (period being the thousand separator in German). I can also still enter "5.5ft". Thanks, Kai Uwe Broulik --===============2033511988857000614== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127802/

Review request for Plasma.

By Kai Uwe Broulik.

Repository: kdeplasma-addons

Description

Only if that fails, it tries QString::toDouble and if even that fails it skips. This allows the user to enter numbers in a more natural way.

Testing

I can now convert "5,5ft" (comma being the decimal indicator in German) or "1.524m" (period being the thousand separator in German).

I can also still enter "5.5ft".

Diffs

runners/converter/converterrunner.cpp (d9cffc3)

View Diff

--===============2033511988857000614==-- --===============7276558145713158540== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7276558145713158540==--