[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2016-04-29 14:33:02
Message-ID: 20160429143302.8442.7334 () mimi ! kde ! org
[Download RAW message or body]
--===============4324265461778603309==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On April 29, 2016, 2:06 p.m., David Edmundson wrote:
> > lets get this merged ASAP so we have some time to fix any fallout from it.
>
> Sebastian Kügler wrote:
> But we don't depend on Qt 5.6 yet in workspace. I think the blocker there is that \
> we need Qt 5.6 on the CI system, then we can switch. Incidentally, Qt 5.6 on Plasma \
> Mobile is also getting closer, which I think is also a good thing to have in line.
> David Edmundson wrote:
> https://build.kde.org/view/QT/job/qt5%205.6%20kf5-qt5/ we have Qt5.6 on CI
I'm personally fine with it, but Martin has a point:
<sebas> other thing: should we bump dependency of workspace to Qt 5.6 now that it's \
on CI? <mgraesslin> sebas: my point still holds: not before there is a release which \
actually works <sebas> for master?
<mgraesslin> yes, even for master
<sebas> that does not matter, assuming they'll ever fix it
<mgraesslin> I don't want us to release Plasma 5.7 befor Qt 5.6.1 is out
<sebas> arguably, 5.6 works better in some areas than 5.5
<mgraesslin> Qt 5.6.0 doesn't even start
<sebas> what's still broken though?
<mgraesslin> 5.6.0 released with a dbus deadlock in kded
<mgraesslin> one cannot start a Plasma session without a patched Qt
<sebas> ah, and patch is in Qt 5.6 branch, but not 5.6.0?
<mgraesslin> yes
<sebas> k, thanks
-*- sebas replies to David then
... so, wait until Qt 5.6.1 is out?
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review95021
-----------------------------------------------------------
On March 17, 2016, 1:02 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 1:02 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Now that everything's in place in Qt, we can do that.
>
> It basically removes all the translation layer between KScreen and QScreen.
>
> NOTE: This can't be merged until Qt 5.6 is a dependency.
>
>
> Diffs
> -----
>
> CMakeLists.txt d407aed
> shell/CMakeLists.txt 7082f32
> shell/panelview.h 1837f96
> shell/panelview.cpp c8c3c71
> shell/shellcorona.h 271d7bf
> shell/shellcorona.cpp 50125bb
>
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
>
>
> Testing
> -------
>
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There \
> could be crashes, I just didn't find them :D)
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============4324265461778603309==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125451/">https://git.reviewboard.kde.org/r/125451/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 29th, 2016, 2:06 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">lets get this merged ASAP so we have some time to fix \
any fallout from it.</p></pre> </blockquote>
<p>On April 29th, 2016, 2:16 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But \
we don't depend on Qt 5.6 yet in workspace. I think the blocker there is that we need \
Qt 5.6 on the CI system, then we can switch. Incidentally, Qt 5.6 on Plasma Mobile is \
also getting closer, which I think is also a good thing to have in line.</p></pre> \
</blockquote>
<p>On April 29th, 2016, 2:18 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://build.kde.org/view/QT/job/qt5%205.6%20kf5-qt5/ we have Qt5.6 on \
CI</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
personally fine with it, but Martin has a point:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><sebas> other thing: should we bump dependency of workspace to Qt 5.6 \
now that it's on CI? <mgraesslin> sebas: my point still holds: not before there \
is a release which actually works <sebas> for master?
<mgraesslin> yes, even for master
<sebas> that does not matter, assuming they'll ever fix it
<mgraesslin> I don't want us to release Plasma 5.7 befor Qt 5.6.1 is out
<sebas> arguably, 5.6 works better in some areas than 5.5
<mgraesslin> Qt 5.6.0 doesn't even start
<sebas> what's still broken though?
<mgraesslin> 5.6.0 released with a dbus deadlock in kded
<mgraesslin> one cannot start a Plasma session without a patched Qt
<sebas> ah, and patch is in Qt 5.6 branch, but not 5.6.0?
<mgraesslin> yes
<sebas> k, thanks
-*- sebas replies to David then</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">... so, wait until Qt 5.6.1 is out?</p></pre> <br />
<p>- Sebastian</p>
<br />
<p>On March 17th, 2016, 1:02 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 17, 2016, 1:02 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now that everything's in place in Qt, we can do \
that.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It basically removes all the translation layer between \
KScreen and QScreen.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">NOTE: This can't be merged until Qt 5.6 \
is a dependency.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hands-on testing, it's been working quite fluid and I \
couldn't find a crash. (There could be crashes, I just didn't find them :D)</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d407aed)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(7082f32)</span></li>
<li>shell/panelview.h <span style="color: grey">(1837f96)</span></li>
<li>shell/panelview.cpp <span style="color: grey">(c8c3c71)</span></li>
<li>shell/shellcorona.h <span style="color: grey">(271d7bf)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(50125bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125451/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4324265461778603309==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic