[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127789: Media Controller: Fix playing next/previous song seeking
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-04-29 13:11:07
Message-ID: 20160429131107.8442.40344 () mimi ! kde ! org
[Download RAW message or body]
--===============2289265347744300217==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127789/#review95018
-----------------------------------------------------------
Fix it, then Ship it!
Lgtm, thanks
It probably still sends a seek command but at least now it no longer sends one to the \
middle of the file :)
applets/mediacontroller/contents/ui/ExpandedRepresentation.qml (line 282)
<https://git.reviewboard.kde.org/r/127789/#comment64496>
Please just write "Bug 1234" without the hash sign
And space after //
- Kai Uwe Broulik
On April 29, 2016, 1:06 nachm., Rajeesh K V wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127789/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 1:06 nachm.)
>
>
> Review request for Plasma and Kai Uwe Broulik.
>
>
> Bugs: 362473
> https://bugs.kde.org/show_bug.cgi?id=362473
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Seems the Slider value is not reset when Next/Previous buttons are pressed in Media \
> Controller widget. This causes next/previous song to seek the slider position \
> instead of starting from beginning.
>
> Diffs
> -----
>
> applets/mediacontroller/contents/ui/ExpandedRepresentation.qml 628e08a
>
> Diff: https://git.reviewboard.kde.org/r/127789/diff/
>
>
> Testing
> -------
>
> Tested against 5.6.2, on local system.
>
>
> Thanks,
>
> Rajeesh K V
>
>
--===============2289265347744300217==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127789/">https://git.reviewboard.kde.org/r/127789/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lgtm, \
thanks</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It probably still sends a seek command but at least \
now it no longer sends one to the middle of the file :)</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127789/diff/1/?file=461546#file461546line282" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/mediacontroller/contents/ui/ExpandedRepresentation.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">282</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">seekSlider</span><span class="p">.</span><span \
class="nx">value</span> <span class="o">=</span> <span class="mi">0</span> <span \
class="c1">//Let the song start from beginning. bug#362473</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please just write "Bug 1234" without the hash sign And space after \
//</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On April 29th, 2016, 1:06 nachm. UTC, Rajeesh K V wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Kai Uwe Broulik.</div>
<div>By Rajeesh K V.</div>
<p style="color: grey;"><i>Updated April 29, 2016, 1:06 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=362473">362473</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Seems the Slider value is not reset when Next/Previous \
buttons are pressed in Media Controller widget. This causes next/previous song to \
seek the slider position instead of starting from beginning.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested against 5.6.2, on local system.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/mediacontroller/contents/ui/ExpandedRepresentation.qml <span \
style="color: grey">(628e08a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127789/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2289265347744300217==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic