From kde-panel-devel Fri Apr 29 11:30:26 2016 From: David Edmundson Date: Fri, 29 Apr 2016 11:30:26 +0000 To: kde-panel-devel Subject: Re: Review Request 127780: Don't open kdeglobals explicitly in font/hint settings. Message-Id: <20160429113026.8442.36430 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146192946327497 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3552318386839551356==" --===============3552318386839551356== Content-Type: multipart/alternative; boundary="===============8239923735308515105==" --===============8239923735308515105== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127780/ ----------------------------------------------------------- (Updated April 29, 2016, 11:30 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit b1d8e32b7bae92ddbdee75425576a8d2f8ca41ba by David Edmundson to branch master. Repository: plasma-integration Description ------- The app config (KSharedConfig::openConfig()) is a mix of the app's settings and kdeglobals. Loading kdeglobals directly not only is a waste of resources, but breaks one of the key features of KConfig where a user can override global settings on a per app basis. What's worse is that KColorScheme when used directly does use the app config, so some apps give an inconsistent mix of results if you try and override settings. Diffs ----- src/platformtheme/kfontsettingsdata.cpp 94edfcbc4f11c5a6ae12cdeb17e4dcec3da5d360 src/platformtheme/khintssettings.cpp 2c4ab44366a3d2caac85a361c759aaf5a0a12fda Diff: https://git.reviewboard.kde.org/r/127780/diff/ Testing ------- Thanks, David Edmundson --===============8239923735308515105== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127780/

This change has been marked as submitted.

Review request for Plasma.

By David Edmundson.

Updated April 29, 2016, 11:30 a.m.

Changes

Submitted with commit b1d8e32b7bae92ddbdee75425576a8d2f8ca41ba by David Edmundson to branch master.

Repository: plasma-integration

Description

The app config (KSharedConfig::openConfig()) is a mix of the app's settings and kdeglobals.

Loading kdeglobals directly not only is a waste of resources, but breaks one of the key features of KConfig where a user can override global settings on a per app basis.

What's worse is that KColorScheme when used directly does use the app config, so some apps give an inconsistent mix of results if you try and override settings.

Diffs

src/platformtheme/kfontsettingsdata.cpp (94edfcbc4f11c5a6ae12cdeb17e4dcec3da5d360)
src/platformtheme/khintssettings.cpp (2c4ab44366a3d2caac85a361c759aaf5a0a12fda)

View Diff

--===============8239923735308515105==-- --===============3552318386839551356== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============3552318386839551356==--