[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125648: Add method to run a script from DBus directly
From: Marco Martin <notmart () gmail ! com>
Date: 2016-04-29 9:42:43
Message-ID: 20160429094243.8442.95847 () mimi ! kde ! org
[Download RAW message or body]
--===============8483853669565888298==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125648/#review95005
-----------------------------------------------------------
Ship it!
last change i would like is to not run the script if widgets are locked
- Marco Martin
On Oct. 15, 2015, 5:22 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125648/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 5:22 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> loadScriptInInteractiveConsole requires user interaction which blocks
> some purposes, like setting the desktop background from an app.
>
> This runs a given script directly from a passed string without any prompts.
>
>
> CCBUG: 217950
>
> ---
>
> Questions:
>
> I also toyed with returning the value of a script as a QDBusVariant, thoughts?
>
> Should I not run if widgets are locked?
>
>
> Diffs
> -----
>
> shell/dbus/org.kde.PlasmaShell.xml cf2d0bbfcdb5720bf19d42403ee8c7fd542adecd
> shell/shellcorona.h 0e6fe041787b2f75d791b38661b63614e27d33bf
> shell/shellcorona.cpp 37d05347d67b7178db4d29a1ac368aacaacf0c0a
>
> Diff: https://git.reviewboard.kde.org/r/125648/diff/
>
>
> Testing
> -------
>
> Ran this:
> var allDesktops = desktops();
> print (allDesktops);
>
> for (i=0;i<allDesktops.length;i++) {
> d = allDesktops[i];
> d.wallpaperPlugin = "org.kde.image";
> d.currentConfigGroup = Array("Wallpaper", "org.kde.image", "General");
> d.writeConfig("Image", \
> "file:///home/david/pictures/Wallpapers/northern_lights-wide.jpg") }
>
>
> also ran some with errors, that behaved as expected too.
>
>
> Thanks,
>
> David Edmundson
>
>
--===============8483853669565888298==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125648/">https://git.reviewboard.kde.org/r/125648/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">last \
change i would like is to not run the script if widgets are locked</p></pre> <br />
<p>- Marco Martin</p>
<br />
<p>On October 15th, 2015, 5:22 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2015, 5:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">loadScriptInInteractiveConsole requires user \
interaction which blocks some purposes, like setting the desktop background from an \
app.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This runs a given script directly from a passed string \
without any prompts.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">CCBUG: 217950</p> <hr \
style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px \
solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Questions:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I also toyed with returning the value of a script as a QDBusVariant, \
thoughts?</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Should I not run if widgets are locked?</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran this: var allDesktops = desktops();
print (allDesktops);</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">for (i=0;i<allDesktops.length;i++) { d = \
allDesktops[i]; d.wallpaperPlugin = "org.kde.image";
d.currentConfigGroup = Array("Wallpaper", "org.kde.image", "General");
d.writeConfig("Image", \
"file:///home/david/pictures/Wallpapers/northern_lights-wide.jpg") }</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">also ran some with errors, that behaved as expected \
too.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/dbus/org.kde.PlasmaShell.xml <span style="color: \
grey">(cf2d0bbfcdb5720bf19d42403ee8c7fd542adecd)</span></li>
<li>shell/shellcorona.h <span style="color: \
grey">(0e6fe041787b2f75d791b38661b63614e27d33bf)</span></li>
<li>shell/shellcorona.cpp <span style="color: \
grey">(37d05347d67b7178db4d29a1ac368aacaacf0c0a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125648/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8483853669565888298==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic