From kde-panel-devel Thu Apr 28 20:55:47 2016 From: Martin Klapetek Date: Thu, 28 Apr 2016 20:55:47 +0000 To: kde-panel-devel Subject: Re: Review Request 127586: [calendar] Add a mark to days containing events Message-Id: <20160428205547.8442.9496 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146187697514322 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8213205536978358443==" --===============8213205536978358443== Content-Type: multipart/alternative; boundary="===============5733892189429487077==" --===============5733892189429487077== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote: > > You broke the zoomed out view, ie. in the year/decade overview you now get a tick at *every* cell... Oops, I'll fix, thanks. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94987 ----------------------------------------------------------- On April 21, 2016, 5:41 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127586/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 5:41 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Simple triangle at the bottom right corner, see screenshot. > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.h 1849ada > src/declarativeimports/calendar/calendar.cpp 0c525b7 > src/declarativeimports/calendar/daysmodel.h 8ab232e > src/declarativeimports/calendar/daysmodel.cpp bf99874 > src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 > src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 > > Diff: https://git.reviewboard.kde.org/r/127586/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png > > > Thanks, > > Martin Klapetek > > --===============5733892189429487077== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/

On April 28th, 2016, 8:44 p.m. CEST, Kai Uwe Broulik wrote:

You broke the zoomed out view, ie. in the year/decade overview you now get a tick at every cell...
Oops, I'll fix, thanks.

- Martin


On April 21st, 2016, 5:41 a.m. CEST, Martin Klapetek wrote:

Review request for KDE Frameworks and Plasma.
By Martin Klapetek.

Updated April 21, 2016, 5:41 a.m.

Repository: plasma-framework

Description 

Simple triangle at the bottom right corner, see screenshot.

Diffs

  • src/declarativeimports/calendar/calendar.h (1849ada)
  • src/declarativeimports/calendar/calendar.cpp (0c525b7)
  • src/declarativeimports/calendar/daysmodel.h (8ab232e)
  • src/declarativeimports/calendar/daysmodel.cpp (bf99874)
  • src/declarativeimports/calendar/qml/DayDelegate.qml (6353827)
  • src/declarativeimports/calendar/qml/DaysCalendar.qml (d4b8fe4)

View Diff

File Attachments

  • Screenshot
    		•
    --===============5733892189429487077==-- --===============8213205536978358443== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8213205536978358443==--