[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2016-04-28 10:36:43
Message-ID: 20160428103643.8442.84989 () mimi ! kde ! org
[Download RAW message or body]
--===============2978145815361003223==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Април 28, 2016, 11:35 преди обяд, Thomas Pfeiffer wrote:
> > Thank you for providing a screenshot!
> >
> > Now I just need to understand what problem this applet is supposed to solve.
> > The original problem Sebas wanted to solve was that "Show Desktop" hid the panel. \
> > That has been fixed in Show Desktop.
> > What problem does Show Desktop still have which this applet tries to solve?
For me there's no problem. I was asked from users to make this applet available, \
because it was present on KaOS with Sebas' diff, but with 5.6 this diff was \
incompatible. So i posted it on kde-look \
http://kde-look.org/content/show.php?action=content&content=175817 Compilation can be \
problem for normal users so Sebas ask me to return it at home. That's it :)
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127651/#review94945
-----------------------------------------------------------
On Април 28, 2016, 11:11 преди обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127651/
> -----------------------------------------------------------
>
> (Updated Април 28, 2016, 11:11 преди обяд)
>
>
> Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian Kügler.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> ^^
>
>
> Diffs
> -----
>
> applets/CMakeLists.txt e591c81
> applets/minimizeall/CMakeLists.txt PRE-CREATION
> applets/minimizeall/Messages.sh PRE-CREATION
> applets/minimizeall/package/contents/config/main.xml PRE-CREATION
> applets/minimizeall/package/contents/ui/main.qml PRE-CREATION
> applets/minimizeall/package/metadata.desktop PRE-CREATION
> applets/minimizeall/plugin/minimizeall.h PRE-CREATION
> applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION
> applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION
> applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION
> applets/minimizeall/plugin/qmldir PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/127651/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot_20160428_110625.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2dc7f4c9-c10a-4166-95d7-67418ad9ce7f__Screenshot_20160428_110625.png
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============2978145815361003223==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127651/">https://git.reviewboard.kde.org/r/127651/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Април 28th, 2016, 11:35 преди \
обяд EEST, <b>Thomas Pfeiffer</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank you for providing \
a screenshot!</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now I just need to understand what problem this applet \
is supposed to solve. The original problem Sebas wanted to solve was that "Show \
Desktop" hid the panel. That has been fixed in Show Desktop.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
problem does Show Desktop still have which this applet tries to solve?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
me there's no problem. I was asked from users to make this applet available, because \
it was present on KaOS with Sebas' diff, but with 5.6 this diff was incompatible. So \
i posted it on kde-look \
http://kde-look.org/content/show.php?action=content&content=175817 Compilation \
can be problem for normal users so Sebas ask me to return it at home. That's it \
:)</p></pre> <br />
<p>- Anthony</p>
<br />
<p>On Април 28th, 2016, 11:11 преди обяд EEST, Anthony Fieroni \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian \
Kügler.</div> <div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Април 28, 2016, 11:11 преди \
обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">^^</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(e591c81)</span></li>
<li>applets/minimizeall/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/minimizeall.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/minimizeall.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/minimizeallplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/minimizeallplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127651/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2dc7f4c9 \
-c10a-4166-95d7-67418ad9ce7f__Screenshot_20160428_110625.png">Screenshot_20160428_110625.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2978145815361003223==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic