[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127753: [toolbutton] Tool button disappear when move fast hover from him to task 
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-04-28 7:13:36
Message-ID: 20160428071336.19318.90933 () mimi ! kde ! org
[Download RAW message or body]

--===============0203997058071794990==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127753/
-----------------------------------------------------------

(Updated Април 28, 2016, 10:13 преди обяд)


Review request for Plasma, Kai Uwe Broulik and David Rosca.


Changes
-------

It has notice one frame 'glitch' resize in tooltip transition from model.IsLauncher \
to !model.IsLauncher in Task.qml. I can't understaind who makes the resize \
QShowEvent(Show, 0x7ffc7bec4ce0) ToolTip_QML_179(0x4556d10) // <------------- this is \
(model.IsLauncher == true) QExposeEvent(QRegion(0,0 376x77)) \
ToolTip_QML_179(0x4556d10)

QExposeEvent(QRegion(0,0 376x180)) ToolTip_QML_179(0x45b5f60) // <------------ \
transitions to (model.IsLauncher != true) QResizeEvent(376, 180) \
ToolTip_QML_179(0x45b5f60)             // <------------ someome makes resize (new \
height-old height) 253-77 this is WRONG QMoveEvent(109,554) \
ToolTip_QML_179(0x45b5f60) QResizeEvent(376, 253) ToolTip_QML_179(0x45b5f60) // \
<-------------------- exactly the new height 253 QMoveEvent(109,481) \
ToolTip_QML_179(0x45b5f60) QMoveEvent(109,554) ToolTip_QML_179(0x45b5f60)
QMoveEvent(109,481) ToolTip_QML_179(0x45b5f60)
QExposeEvent(QRegion(0,0 376x253)) ToolTip_QML_179(0x45b5f60)
QMouseEvent(MouseMove, localPos=167,201, screenPos=276,755) \
ToolTip_QML_179(0x45b5f60) QExposeEvent(QRegion(0,0 376x253)) \
ToolTip_QML_179(0x45b5f60) QHideEvent(Hide, 0x7ffc7bec4d10) \
ToolTip_QML_179(0x45b5f60) QExposeEvent(QRegion(null)) ToolTip_QML_179(0x45b5f60)


Repository: plasma-desktop


Description
-------

I have no idea why 'enabled: visible' did that work


Diffs
-----

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 383c4a4 

Diff: https://git.reviewboard.kde.org/r/127753/diff/


Testing
-------

Tool button is drawed correctly


File Attachments (updated)
----------------

Move mouse pointer fast from here to taskmanager item
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/27/382fc7df-83c8-4555-9952-5cc3f4c1a637__Screenshot_20160427_111049.png
 toolbutton disappear
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/27/4459dbb7-83f6-49f1-b412-bd3a3b514044__Screenshot_20160427_111017.png
 Screenshot_20160428_100159.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/84cf7fb4-6b18-40eb-bb8b-8c796375300f__Screenshot_20160428_100159.png



Thanks,

Anthony Fieroni


--===============0203997058071794990==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127753/">https://git.reviewboard.kde.org/r/127753/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Kai Uwe Broulik and David Rosca.</div>
<div>By Anthony Fieroni.</div>


<p style="color: grey;"><i>Updated Април 28, 2016, 10:13 преди \
обяд</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It has notice one frame &#39;glitch&#39; resize in tooltip transition \
from model.IsLauncher to !model.IsLauncher in Task.qml. I can&#39;t understaind who \
makes the resize QShowEvent(Show, 0x7ffc7bec4ce0) ToolTip_QML_179(0x4556d10) // \
&lt;------------- this is (model.IsLauncher == true) QExposeEvent(QRegion(0,0 \
376x77)) ToolTip_QML_179(0x4556d10)

QExposeEvent(QRegion(0,0 376x180)) ToolTip_QML_179(0x45b5f60) // &lt;------------ \
transitions to (model.IsLauncher != true) QResizeEvent(376, 180) \
ToolTip_QML_179(0x45b5f60)             // &lt;------------ someome makes resize (new \
height-old height) 253-77 this is WRONG QMoveEvent(109,554) \
ToolTip_QML_179(0x45b5f60) QResizeEvent(376, 253) ToolTip_QML_179(0x45b5f60) // \
&lt;-------------------- exactly the new height 253 QMoveEvent(109,481) \
ToolTip_QML_179(0x45b5f60) QMoveEvent(109,554) ToolTip_QML_179(0x45b5f60)
QMoveEvent(109,481) ToolTip_QML_179(0x45b5f60)
QExposeEvent(QRegion(0,0 376x253)) ToolTip_QML_179(0x45b5f60)
QMouseEvent(MouseMove, localPos=167,201, screenPos=276,755) \
ToolTip_QML_179(0x45b5f60) QExposeEvent(QRegion(0,0 376x253)) \
ToolTip_QML_179(0x45b5f60) QHideEvent(Hide, 0x7ffc7bec4d10) \
ToolTip_QML_179(0x45b5f60) QExposeEvent(QRegion(null)) \
ToolTip_QML_179(0x45b5f60)</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have no idea why 'enabled: visible' did that \
work</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tool button is drawed correctly</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/package/contents/ui/ToolTipDelegate.qml <span style="color: \
grey">(383c4a4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127753/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/27/382fc7df-83c8-4555-9952-5cc3f4c1a637__Screenshot_20160427_111049.png">Move \
mouse pointer fast from here to taskmanager item</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/27/4459dbb7-83f6-49f1-b412-bd3a3b514044__Screenshot_20160427_111017.png">toolbutton \
disappear</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/84cf7fb4 \
-6b18-40eb-bb8b-8c796375300f__Screenshot_20160428_100159.png">Screenshot_20160428_100159.png</a></li>


</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0203997058071794990==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic