[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Updated] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the 
From:       "dfaure (David Faure)" <noreply () phabricator ! kde ! org>
Date:       2016-04-26 19:32:10
Message-ID: 20160426193151.35281.52760.2AA890B5 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


dfaure added a comment.


  I'm pretty sure it should work. What changed in QUrl is that setPath used to \
normalize the path and doesn't do that anymore.  (qtbase commit 2e1de7f3c4ca). So in \
5.5 the double slash got simplified to a single slash, while in 5.6 it stays and \
breaks the test.  Not putting a double slash in the first place will work with both \
Qt versions.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  fix-kioslave-desktop

REVISION DETAIL
  https://phabricator.kde.org/D1497

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, hein, dfaure
Cc: plasma-devel, sebas


[Attachment #5 (text/html)]

<div>dfaure added a comment.</div><br /><div><div><p>I&#039;m pretty sure it should \
work. What changed in QUrl is that setPath used to normalize the path and \
doesn&#039;t do that anymore.<br /> (qtbase commit 2e1de7f3c4ca). So in 5.5 the \
double slash got simplified to a single slash, while in 5.6 it stays and breaks the \
test.<br /> Not putting a double slash in the first place will work with both Qt \
versions.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>fix-kioslave-desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1497" \
rel="noreferrer">https://phabricator.kde.org/D1497</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, Plasma, hein, dfaure<br /><strong>Cc: \
</strong>plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]