[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127263: Add Wireless Energy Saving action
From: Thomas Pfeiffer <thomas.pfeiffer () kde ! org>
Date: 2016-04-22 14:48:06
Message-ID: 20160422144806.31741.70914 () mimi ! kde ! org
[Download RAW message or body]
--===============7616662421236214878==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 9, 2016, 2:47 p.m., Thomas Pfeiffer wrote:
> > Thank you for the screenshot!
> > It looks good to me, the only thing I'd change is relabeling "Manual \
> > configuration" to "Leave unchanged" (and changing functionality if that isn't \
> > what it does atm) and putting that as the first option and making it the default.
>
> Jan Grulich wrote:
> That's what it does, it basically does nothing and leaves this to the user to \
> manage his wifi/wwan/bt through plasma-nm or the bluetooth applet.
Have you changed the label and moved it to first position yet?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127263/#review93334
-----------------------------------------------------------
On March 9, 2016, 4:15 p.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127263/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 4:15 p.m.)
>
>
> Review request for Plasma, Solid, KDE Usability, and Kai Uwe Broulik.
>
>
> Repository: powerdevil
>
>
> Description
> -------
>
> This action adds an option to turn off wifi/wwan/bt once you switch profile (e.g \
> you unplugg the power cable and start running on battery).
> One more thing. Due to usage of NetworkManagerQt I had to add \
> add_definitions(-DQT_NO_KEYWORDS) into CMakeLists.txt like we do in plasma-nm to \
> avoid compilation error (thanks to NetworkManager) and replace all keywords by \
> their Qt equivalent (e.g signals ? Q_SIGNALS).
> How it behaves:
> 1) Switching from "AC" profile to "battery" (or from "battery" to "low battery" \
> which is the same situation): a) When the action is enabled in "AC" profile and \
> options to turn off wifi/wwan/bt are enabled x) Switching to a profile where the \
> action is enabled too and options are turned on ? will do nothing as they should be \
> already turned off y) Switching to a profile where the action is enabled too but \
> options are turned off ? will do nothing as the "battery" profile is more \
> conservative and we have those devices disabled already in less conservative \
> profile z) Switching to a profile where the action is disabled ? will do nothing as \
> there is nothing to do b) When the action is enabled in "AC" profile and options to \
> turn off wifi/wwan/bt are disabled ? this should behave according to the more \
> conservative profile, if the options are enabled then all devices will be disabled \
> too C) When the action is disabled in "AC" profile
> ? should behave as in the case 1-b
> 2) Switching from "battery" profile to "AC" profile (or from "low battery" to \
> "battery" which is the same situation): a) When the action is enabled in "battery" \
> profile and options to turn off wifi/wwan/bt are enabled x) Switching to a profile \
> where the action is enabled too and options are turned on ? will do nothing as it's \
> same setup y) Switching to a profile where the action is enabled too and options \
> are turned off ? will turn on the wifi/wwan/bt z) Switching to a profile where the \
> action is disabled ? will recover the previous state of the wifi/wwan/bt b) When \
> the action is enabled in "battery" profile and options to turn off wifi/wwan/bt are \
> disabled x) Switching to a profile where the action is enabled too and options are \
> turned on ? will do nothing as the option in "battery" should be ignored in this \
> case due to more conservative profile y) Switching to a profile where the action is \
> enabled too and options are turned off ? will do nothing, same configuration z) \
> Switching to a profile where the action is disabled ? will recover the previous \
> state of the wifi/wwan/bt c) When the action is diabled in "battery" profile
> ? will just recover the previous state of the wifi/wwan/bt as there is nothing to \
> change according to the new profile
>
> Diffs
> -----
>
> CMakeLists.txt e7fff17
> daemon/CMakeLists.txt bbfe191
> daemon/actions/bundled/CMakeLists.txt 45abea3
> daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.WirelessPowerSaving.xml \
> PRE-CREATION daemon/actions/bundled/powerdevilwirelesspowersavingaction.desktop \
> PRE-CREATION daemon/actions/bundled/wirelesspowersaving.h PRE-CREATION
> daemon/actions/bundled/wirelesspowersaving.cpp PRE-CREATION
> daemon/actions/bundled/wirelesspowersavingconfig.h PRE-CREATION
> daemon/actions/bundled/wirelesspowersavingconfig.cpp PRE-CREATION
> daemon/powerdevilactionpool.cpp 2091879
>
> Diff: https://git.reviewboard.kde.org/r/127263/diff/
>
>
> Testing
> -------
>
> I did some basic testing like (un)plugging the power cable and checking whether it \
> applied the correct configuration.
>
> Thanks,
>
> Jan Grulich
>
>
--===============7616662421236214878==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127263/">https://git.reviewboard.kde.org/r/127263/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 9th, 2016, 2:47 p.m. UTC, <b>Thomas \
Pfeiffer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thank you for the screenshot! It looks good to me, the \
only thing I'd change is relabeling "Manual configuration" to "Leave unchanged" (and \
changing functionality if that isn't what it does atm) and putting that as the first \
option and making it the default.</p></pre> </blockquote>
<p>On March 9th, 2016, 2:50 p.m. UTC, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That's what it does, it basically does nothing and leaves this to the user \
to manage his wifi/wwan/bt through plasma-nm or the bluetooth applet.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have \
you changed the label and moved it to first position yet?</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On March 9th, 2016, 4:15 p.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Solid, KDE Usability, and Kai Uwe Broulik.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated March 9, 2016, 4:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This action adds an option to turn off wifi/wwan/bt \
once you switch profile (e.g you unplugg the power cable and start running on \
battery).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">One more thing. Due to usage of NetworkManagerQt I had \
to add add_definitions(-DQT_NO_KEYWORDS) into CMakeLists.txt like we do in plasma-nm \
to avoid compilation error (thanks to NetworkManager) and replace all keywords by \
their Qt equivalent (e.g signals ? Q_SIGNALS).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How \
it behaves: 1) Switching from "AC" profile to "battery" (or from "battery" to "low \
battery" which is the same situation): a) When the action is enabled in "AC" profile \
and options to turn off wifi/wwan/bt are enabled
x) Switching to a profile where the action is enabled too and options are \
turned on ? will do nothing as they should be already turned off y) Switching to a \
profile where the action is enabled too but options are turned off ? will do nothing \
as the "battery" profile is more conservative and we have those devices disabled \
already in less conservative profile
z) Switching to a profile where the action is disabled ? will do nothing as \
there is nothing to do b) When the action is enabled in "AC" profile and options to \
turn off wifi/wwan/bt are disabled
? this should behave according to the more conservative profile, if the options \
are enabled then all devices will be disabled too C) When the action is disabled in \
"AC" profile ? should behave as in the case 1-b
2) Switching from "battery" profile to "AC" profile (or from "low battery" to \
"battery" which is the same situation): a) When the action is enabled in "battery" \
profile and options to turn off wifi/wwan/bt are enabled
x) Switching to a profile where the action is enabled too and options are \
turned on ? will do nothing as it's same setup
y) Switching to a profile where the action is enabled too and options are \
turned off ? will turn on the wifi/wwan/bt
z) Switching to a profile where the action is disabled ? will recover the \
previous state of the wifi/wwan/bt b) When the action is enabled in "battery" \
profile and options to turn off wifi/wwan/bt are disabled x) Switching to a profile \
where the action is enabled too and options are turned on ? will do nothing as the \
option in "battery" should be ignored in this case due to more \
conservative profile
y) Switching to a profile where the action is enabled too and options are \
turned off ? will do nothing, same configuration
z) Switching to a profile where the action is disabled ? will recover the \
previous state of the wifi/wwan/bt c) When the action is diabled in "battery" \
profile
? will just recover the previous state of the wifi/wwan/bt as there is nothing \
to change according to the new profile</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I did some basic testing like (un)plugging the power \
cable and checking whether it applied the correct configuration.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e7fff17)</span></li>
<li>daemon/CMakeLists.txt <span style="color: grey">(bbfe191)</span></li>
<li>daemon/actions/bundled/CMakeLists.txt <span style="color: \
grey">(45abea3)</span></li>
<li>daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.WirelessPowerSaving.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/bundled/powerdevilwirelesspowersavingaction.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/bundled/wirelesspowersaving.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>daemon/actions/bundled/wirelesspowersaving.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>daemon/actions/bundled/wirelesspowersavingconfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>daemon/actions/bundled/wirelesspowersavingconfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>daemon/powerdevilactionpool.cpp <span style="color: grey">(2091879)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127263/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7616662421236214878==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic