[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127586: [calendar] Add a mark to days containing events
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2016-04-14 1:16:21
Message-ID: 20160414011621.15182.71344 () mimi ! kde ! org
[Download RAW message or body]
--===============3960773762007003740==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?
>
> Martin Klapetek wrote:
> Working on it.
Ok so I'm unable to render that svg, it is properly installed
and everything, but this doesn't show anything (not even error):
```
PlasmaCore.Svg {
id: calendarSvg
imagePath: "widgets/calendar"
}
PlasmaCore.SvgItem {
id: eventsMarker
width: parent.width / 3
height: parent.height / 3
svg: calendarSvg
elementId: "event"
}
```
...is it missing anything? If I use say "widgets/clock" and "ClockFace", it works \
fine.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
-----------------------------------------------------------
On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:53 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Simple triangle at the bottom right corner, see screenshot.
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/daysmodel.h 8ab232e
> src/declarativeimports/calendar/daysmodel.cpp bf99874
> src/declarativeimports/calendar/qml/DayDelegate.qml 6353827
> src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4
>
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============3960773762007003740==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127586/">https://git.reviewboard.kde.org/r/127586/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 13th, 2016, 10:28 a.m. CEST, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">what's the status of this?</p></pre> </blockquote>
<p>On April 13th, 2016, 2:54 p.m. CEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Working on it.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok so \
I'm unable to render that svg, it is properly installed and everything, but this \
doesn't show anything (not even error):</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"> PlasmaCore.Svg { id: \
calendarSvg imagePath: "widgets/calendar"
}
PlasmaCore.SvgItem {
id: eventsMarker
width: parent.width / 3
height: parent.height / 3
svg: calendarSvg
elementId: "event"
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">...is it missing anything? If I use say \
"widgets/clock" and "ClockFace", it works fine.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On April 6th, 2016, 5:53 a.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 6, 2016, 5:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Simple triangle at the bottom right corner, see \
screenshot.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/daysmodel.h <span style="color: \
grey">(8ab232e)</span></li>
<li>src/declarativeimports/calendar/daysmodel.cpp <span style="color: \
grey">(bf99874)</span></li>
<li>src/declarativeimports/calendar/qml/DayDelegate.qml <span style="color: \
grey">(6353827)</span></li>
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(d4b8fe4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127586/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3960773762007003740==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic