[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127586: [calendar] Add a mark to days containing events
From: Marco Martin <notmart () gmail ! com>
Date: 2016-04-07 15:43:12
Message-ID: 20160407154312.15005.42193 () mimi ! kde ! org
[Download RAW message or body]
--===============5016216958291037043==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they all \
> > have their own FBO.
> > Can't you make the grid canvas draw the triangles, too? Or make a simple item \
> > with a triangle shaped QSGGeometryNode?
>
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D \
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can I just \
> copy that directly and put that licence in the header and ship this in frameworks?
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
>
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get back
>
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
>
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?
>
> Martin Klapetek wrote:
> Yes. Make it the highlight color of the theme (or I guess I'll be able to color it \
> from the code right?)
> Marco Martin wrote:
> the svg would be always "highlight color" whatever is the theme.
> you would need other colors?
> i'll sooner or later add some api to manipulate the stylesheet from the code, but \
> that's not available yet
> Martin Klapetek wrote:
> I considered having different colors by event type (holiday vs calendar event), but \
> I guess a single color will do for now.
done.
widgets/calendar, loaded in a SvgItem
the element id is "event" that is just a triangle like in the screenshots
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
-----------------------------------------------------------
On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 3:53 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Simple triangle at the bottom right corner, see screenshot.
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/daysmodel.h 8ab232e
> src/declarativeimports/calendar/daysmodel.cpp bf99874
> src/declarativeimports/calendar/qml/DayDelegate.qml 6353827
> src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4
>
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============5016216958291037043==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127586/">https://git.reviewboard.kde.org/r/127586/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 6th, 2016, 7:03 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You really don't want to create more Canvas elements \
than neccessary, they all have their own FBO.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can't \
you make the grid canvas draw the triangles, too? Or make a simple item with a \
triangle shaped QSGGeometryNode?</p></pre> </blockquote>
<p>On April 6th, 2016, 7:34 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">There's even exactly that on WikiBooks :D \
https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation</p></pre> \
</blockquote>
<p>On April 6th, 2016, 11:33 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, \
that's handy. Now I wonder though - it's under CC-BY-SA licence, can I just copy that \
directly and put that licence in the header and ship this in frameworks?</p></pre> \
</blockquote>
<p>On April 7th, 2016, 6:18 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would say that is not copyrightable, it's too trivial.</p></pre> </blockquote>
<p>On April 7th, 2016, 8:25 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would prefer adding it to the svg theme. there used to be elements for the calendar \
in the theme, they could get back</p></pre> </blockquote>
<p>On April 7th, 2016, 2:31 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oooh \
that would be nice. Who's in charge of the theme these days?</p></pre> </blockquote>
<p>On April 7th, 2016, 2:46 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can \
add the needed item, is just needed a single item as that triangle?</p></pre> \
</blockquote>
<p>On April 7th, 2016, 3:05 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes. \
Make it the highlight color of the theme (or I guess I'll be able to color it from \
the code right?)</p></pre> </blockquote>
<p>On April 7th, 2016, 3:11 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the \
svg would be always "highlight color" whatever is the theme. you would need other \
colors? i'll sooner or later add some api to manipulate the stylesheet from the code, \
but that's not available yet</p></pre> </blockquote>
<p>On April 7th, 2016, 3:24 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
considered having different colors by event type (holiday vs calendar event), but I \
guess a single color will do for now.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">done. \
widgets/calendar, loaded in a SvgItem the element id is "event" that is just a \
triangle like in the screenshots</p></pre> <br />
<p>- Marco</p>
<br />
<p>On April 6th, 2016, 3:53 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 6, 2016, 3:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Simple triangle at the bottom right corner, see \
screenshot.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/daysmodel.h <span style="color: \
grey">(8ab232e)</span></li>
<li>src/declarativeimports/calendar/daysmodel.cpp <span style="color: \
grey">(bf99874)</span></li>
<li>src/declarativeimports/calendar/qml/DayDelegate.qml <span style="color: \
grey">(6353827)</span></li>
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(d4b8fe4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127586/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5016216958291037043==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic