--===============8224869456456479983== Content-Type: multipart/alternative; boundary="===============8928908826732221121==" --===============8928908826732221121== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On März 31, 2016, 9:08 nachm., Kai Uwe Broulik wrote: > > > to be able to display Virtual, Real or both kind of streams > > > > I don't fully get the concept of "virtual stream", at least not from your screenshot, ie. what happens if I mute the "Chromium: Spotify" stream but not the other? Will it continue playing, or won't or will it magically mute the other one also? > > Yoann Laissus wrote: > Sorry, my screenshots aren't very clear, they were taken in a branch with other features, I juste updated them. > In both screens, you can see two virtual streams, those without a name. They are totally unrelated to the other three streams. > > You can see this concept in action in pavucontrol, there is a combobox for that in Playback / Recording tabs. > I just added the pavucontrol window screen for the same streams as comparaison. Ah, awesome, thanks for clarification! - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/#review94168 ----------------------------------------------------------- On März 31, 2016, 9:29 nachm., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127540/ > ----------------------------------------------------------- > > (Updated März 31, 2016, 9:29 nachm.) > > > Review request for Plasma. > > > Repository: plasma-pa > > > Description > ------- > > Virtual streams appear when virtual devices are defined in PulseAudio configuration (eg: combined output for classic analog and HDMI) > Those virtual streams aren't properly shown in both the KCM and the applet, producing ghost entries. > > Screens attached. > > I added a new property to the Stream object to identify if a stream is real or not. > Then, a proxy model takes care of the filtering in the KCM and the applet. > For now, only real devices are shown. But we could add a combobox later, at least in the KCM, to be able to display Virtual, Real or both kind of streams. (like pavucontrol) > > The branch is here : https://quickgit.kde.org/?p=clones%2Fplasma-pa%2Flaissus%2Fplasma-pa.git&a=shortlog&h=014d6925b0911f9db2dc5f55cec5e5a9a84df8c9 > > PS : Other review requests are coming (sink selection for streams) but needs some rebasing with David Rosca's latest patches. > > > Diffs > ----- > > applet/contents/ui/main.qml cbe63ced145cd6e755511d025df84a536976eac4 > src/kcm/package/contents/ui/StreamView.qml b08c87a2452cadd13bae5b0b94b57c3d8f531b3b > src/kcm/package/contents/ui/main.qml 3360201dd8e2a4b5ab03c82c94e5c79d8af9ea4c > src/pulseaudio.h 9fc9656e84ee4761d9e8dd9d2a7b8c9d0af9e517 > src/pulseaudio.cpp 14887849a04ff2fb3ded5d0d5e60ec3ce4c40745 > src/qml/plugin.cpp 5743253f9a7b8283d2bcbeeb081d0706ba4c7b12 > src/stream.h b5e09ebaaa0b812f3db81e269671640c783e7c87 > src/stream.cpp d8f390805e96bbc2dc69ca02520c049b2ca0a4b6 > > Diff: https://git.reviewboard.kde.org/r/127540/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > KCM > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/fd74b564-2e56-45e2-88b9-6bf526f98311__Screenshot_20160331_225655.png > Applet > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_20160331_225554.png > pavucontrol > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/5a872915-dd32-4558-9e4e-947f92f75a70__Screenshot_20160331_231548.png > KCM > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/cdf983ea-032f-4246-95b8-ba9a4d228ccd__Screenshot_20160331_232502.png > Applet > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/1a3d3e3a-6078-445d-84c4-8929cb6243a8__Screenshot_20160331_232444.png > > > Thanks, > > Yoann Laissus > > --===============8928908826732221121== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/

On März 31st, 2016, 9:08 nachm. UTC, Kai Uwe Broulik wrote:



to be able to display Virtual, Real or both kind of streams




I don't fully get the concept of "virtual stream", at least not from your screenshot, ie. what happens if I mute the "Chromium: Spotify" stream but not the other? Will it continue playing, or won't or will it magically mute the other one also?

On März 31st, 2016, 9:28 nachm. UTC, Yoann Laissus wrote:

Sorry, my screenshots aren't very clear, they were taken in a branch with other features, I juste updated them. 
In both screens, you can see two virtual streams, those without a name. They are totally unrelated to the other three streams.


You can see this concept in action in pavucontrol, there is a combobox for that in Playback / Recording tabs.
I just added the pavucontrol window screen for the same streams as comparaison.
Ah, awesome, thanks for clarification!

- Kai Uwe


On März 31st, 2016, 9:29 nachm. UTC, Yoann Laissus wrote:

Review request for Plasma.
By Yoann Laissus.

Updated März 31, 2016, 9:29 nachm.

Repository: plasma-pa

Description 

Virtual streams appear when virtual devices are defined in PulseAudio configuration (eg: combined output for classic analog and HDMI)
Those virtual streams aren't properly shown in both the KCM and the applet, producing ghost entries.


Screens attached.


I added a new property to the Stream object to identify if a stream is real or not.
Then, a proxy model takes care of the filtering in the KCM and the applet.
For now, only real devices are shown. But we could add a combobox later, at least in the KCM, to be able to display Virtual, Real or both kind of streams. (like pavucontrol)


The branch is here : https://quickgit.kde.org/?p=clones%2Fplasma-pa%2Flaissus%2Fplasma-pa.git&a=shortlog&h=014d6925b0911f9db2dc5f55cec5e5a9a84df8c9


PS : Other review requests are coming (sink selection for streams) but needs some rebasing with David Rosca's latest patches.

Diffs

  • applet/contents/ui/main.qml (cbe63ced145cd6e755511d025df84a536976eac4)
  • src/kcm/package/contents/ui/StreamView.qml (b08c87a2452cadd13bae5b0b94b57c3d8f531b3b)
  • src/kcm/package/contents/ui/main.qml (3360201dd8e2a4b5ab03c82c94e5c79d8af9ea4c)
  • src/pulseaudio.h (9fc9656e84ee4761d9e8dd9d2a7b8c9d0af9e517)
  • src/pulseaudio.cpp (14887849a04ff2fb3ded5d0d5e60ec3ce4c40745)
  • src/qml/plugin.cpp (5743253f9a7b8283d2bcbeeb081d0706ba4c7b12)
  • src/stream.h (b5e09ebaaa0b812f3db81e269671640c783e7c87)
  • src/stream.cpp (d8f390805e96bbc2dc69ca02520c049b2ca0a4b6)

View Diff

File Attachments

  • KCM
  • Applet
  • pavucontrol
  • KCM
  • Applet
    		•
    --===============8928908826732221121==-- --===============8224869456456479983== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8224869456456479983==--