[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127260: Experiment: cache svg icons from icon theme
From: Marco Martin <notmart () gmail ! com>
Date: 2016-03-31 13:07:55
Message-ID: 20160331130755.12706.59675 () mimi ! kde ! org
[Download RAW message or body]
--===============6762687888814194248==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/
-----------------------------------------------------------
(Updated March 31, 2016, 1:07 p.m.)
Review request for Plasma.
Changes
-------
added a test that ensures that when the icon theme changes, repaintneeded from the \
svg is emitted. I'm unsure wether to pursue this direction, or rather modifying \
setImagePath as follows:
rather than like now going
when svg->setImagePath("icon/foo") is called (with icon/ prefix)
tries first in the current plasma theme, then in the current icon theme, then in the \
default plasma theme if no actual svg file will be found, svg will be not valid
IconItem component would be modified accordingly
Repository: plasma-framework
Description
-------
this attempts to cache as well svg icons from the icon theme (invalidating as well \
when the icon theme is updated)
still to be done, to figure out to invalidate cache when the icon theme is changed in \
the two cases:
* theme changed with plasmashell running
* theme changed with plasma shell not running
Diffs (updated)
-----
autotests/CMakeLists.txt d475ac3
autotests/data/icons/test-theme-two/apps/22/tst-plasma-framework-test-icon.svg \
PRE-CREATION autotests/data/icons/test-theme-two/index.theme PRE-CREATION
autotests/themetest.h PRE-CREATION
autotests/themetest.cpp PRE-CREATION
src/plasma/private/theme_p.h 69a8934
src/plasma/private/theme_p.cpp 98bccab
src/plasma/svg.cpp 6c9c75c
Diff: https://git.reviewboard.kde.org/r/127260/diff/
Testing
-------
Thanks,
Marco Martin
--===============6762687888814194248==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127260/">https://git.reviewboard.kde.org/r/127260/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated March 31, 2016, 1:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">added a test that ensures that when the icon theme changes, \
repaintneeded from the svg is emitted. I'm unsure wether to pursue this \
direction, or rather modifying setImagePath as follows:
rather than like now going
when svg->setImagePath("icon/foo") is called (with icon/ prefix)
tries first in the current plasma theme, then in the current icon theme, then in the \
default plasma theme if no actual svg file will be found, svg will be not valid
IconItem component would be modified accordingly</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this attempts to cache as well svg icons from the icon \
theme (invalidating as well when the icon theme is updated)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">still \
to be done, to figure out to invalidate cache when the icon theme is changed in the \
two cases: <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> theme changed with plasmashell running </em> theme \
changed with plasma shell not running</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(d475ac3)</span></li>
<li>autotests/data/icons/test-theme-two/apps/22/tst-plasma-framework-test-icon.svg \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/test-theme-two/index.theme <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/themetest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/themetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plasma/private/theme_p.h <span style="color: grey">(69a8934)</span></li>
<li>src/plasma/private/theme_p.cpp <span style="color: grey">(98bccab)</span></li>
<li>src/plasma/svg.cpp <span style="color: grey">(6c9c75c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127260/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6762687888814194248==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic