'Re: Review Request 127484: applet: Add streams tab to manage applications volume'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127484: applet: Add streams tab to manage applications volume
From:       David Rosca <nowrep () gmail ! com>
Date:       2016-03-30 16:26:11
Message-ID: 20160330162611.12706.13881 () mimi ! kde ! org
[Download RAW message or body]

--===============6352855545108842940==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127484/
-----------------------------------------------------------

(Updated March 30, 2016, 4:26 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and KDE Usability.

Changes
-------

Submitted with commit 9ffa6cf6072e34b1e150875e05715d6757a3456e by David Rosca to \
branch master.

Repository: plasma-pa

Description
-------

Applet now have two tabs: Devices and Streams.
If there are more audo devices, streams can be moved between them with combobox that \
is visible after clicking on stream item.

BUG: 352042
BUG: 353232

Diffs
-----

  applet/contents/ui/ListItemBase.qml 2e31eeb 
  applet/contents/ui/SinkInputListItem.qml 3867007 
  applet/contents/ui/SourceOutputListItem.qml 3b684fc 
  applet/contents/ui/StreamListItem.qml PRE-CREATION 
  applet/contents/ui/StreamListItemBase.qml 7c0af12 
  applet/contents/ui/main.qml bf6f683 
  src/pulseaudio.h 9fc9656 
  src/pulseaudio.cpp 1488784 

Diff: https://git.reviewboard.kde.org/r/127484/diff/

Testing
-------

Everything seems to work fine.

File Attachments
----------------

applet-devices.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png
 applet-streams.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png
 applet-streams-more-devices.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png
 applet-streams-more-devices.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png

Thanks,

David Rosca

--===============6352855545108842940==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127484/">https://git.reviewboard.kde.org/r/127484/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated March 30, 2016, 4:26 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 9ffa6cf6072e34b1e150875e05715d6757a3456e by David \
Rosca to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Applet now have two tabs: Devices and Streams. If \
there are more audo devices, streams can be moved between them with combobox that is \
visible after clicking on stream item.</p> <p style="padding: 0;text-rendering: \
                inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: \
                352042
BUG: 353232</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything seems to work fine.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applet/contents/ui/ListItemBase.qml <span style="color: \
grey">(2e31eeb)</span></li>

 <li>applet/contents/ui/SinkInputListItem.qml <span style="color: \
grey">(3867007)</span></li>

 <li>applet/contents/ui/SourceOutputListItem.qml <span style="color: \
grey">(3b684fc)</span></li>

 <li>applet/contents/ui/StreamListItem.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applet/contents/ui/StreamListItemBase.qml <span style="color: \
grey">(7c0af12)</span></li>

 <li>applet/contents/ui/main.qml <span style="color: grey">(bf6f683)</span></li>

 <li>src/pulseaudio.h <span style="color: grey">(9fc9656)</span></li>

 <li>src/pulseaudio.cpp <span style="color: grey">(1488784)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127484/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png">applet-devices.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png">applet-streams.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13 \
-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png">applet-streams-more-devices.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91 \
-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png">applet-streams-more-devices.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6352855545108842940==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 