[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126630: Do not unconditionally enable logging
From: Peter Wu <peter () lekensteyn ! nl>
Date: 2016-03-29 18:16:45
Message-ID: 20160329181645.12706.46457 () mimi ! kde ! org
[Download RAW message or body]
--===============0989996732649947309==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126630/
-----------------------------------------------------------
(Updated March 29, 2016, 6:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Solid, Daniel Vrátil, and Sebastian Kügler.
Changes
-------
Submitted with commit 649dda5e8c8f683f1650b4cf609fe094d22e3290 by Albert Astals Cid \
on behalf of Peter Wu to branch Plasma/5.6.
Repository: libkscreen
Description
-------
Logging is [enabled by default][1], there is no read to use setFilterRules
and [override][2] any user preferences in QtProject/qtlogging.ini.
Keep unconditional logging enabled for the fake backend though, this
ensures that unit tests have log messages even if the user disabled all
other debug messages.
[1]: https://doc.qt.io/qt-5/qloggingcategory.html#Q_LOGGING_CATEGORY
[2]: https://doc.qt.io/qt-5/qloggingcategory.html#configuring-categories
Diffs
-----
backends/kwayland/waylandbackend.cpp 0700e22
backends/qscreen/qscreenbackend.cpp 56b5a7c
backends/xcbeventlistener.cpp ee415d7
backends/xrandr/xrandr.cpp fae1dcc
backends/xrandr1.1/xrandr11.cpp 631bcc9
src/debug_p.cpp 5934417
Diff: https://git.reviewboard.kde.org/r/126630/diff/
Testing
-------
Tested on v5.5.2 (cherry-picked, ignored missing \
backends/kwayland/waylandbackend.cpp).
Test:
1. Have no kscreen related lines in ~/.config/QtProject/qtlogging.ini
2. killall kscreen_backend_launcher
3. Change brightness levels via the keyboard. (Result: `RRNotify_OutputProperty` \
messages in `journalctl`) 4. Add the following lines to qtlogging.ini:
```
kscreen.debug=false
kscreen.xrandr.debug=false
kscreen.xcb.helper.debug=false
```
5. killall kscreen_backend_launcher
6. Change brightness levels again. (Result: no log spam!)
Thanks,
Peter Wu
--===============0989996732649947309==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126630/">https://git.reviewboard.kde.org/r/126630/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Solid, Daniel Vrátil, and Sebastian Kügler.</div>
<div>By Peter Wu.</div>
<p style="color: grey;"><i>Updated March 29, 2016, 6:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 649dda5e8c8f683f1650b4cf609fe094d22e3290 by Albert \
Astals Cid on behalf of Peter Wu to branch Plasma/5.6.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Logging is <a \
href="https://doc.qt.io/qt-5/qloggingcategory.html#Q_LOGGING_CATEGORY" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">enabled by default</a>, there is no read to use setFilterRules and <a \
href="https://doc.qt.io/qt-5/qloggingcategory.html#configuring-categories" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">override</a> any user preferences in QtProject/qtlogging.ini.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Keep unconditional logging enabled for the fake backend though, this \
ensures that unit tests have log messages even if the user disabled all other debug \
messages.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on v5.5.2 (cherry-picked, ignored missing \
backends/kwayland/waylandbackend.cpp).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Test:</p> <ol \
style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Have no kscreen related lines in \
~/.config/QtProject/qtlogging.ini</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">killall \
kscreen_backend_launcher</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Change brightness levels via the \
keyboard. (Result: <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">RRNotify_OutputProperty</code> \
messages in <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">journalctl</code>)</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Add the following lines to qtlogging.ini:</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">kscreen.debug=false \
kscreen.xrandr.debug=false kscreen.xcb.helper.debug=false
</pre></div>
</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">killall kscreen_backend_launcher</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Change brightness levels again. (Result: no log \
spam!)</li> </ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/kwayland/waylandbackend.cpp <span style="color: \
grey">(0700e22)</span></li>
<li>backends/qscreen/qscreenbackend.cpp <span style="color: \
grey">(56b5a7c)</span></li>
<li>backends/xcbeventlistener.cpp <span style="color: grey">(ee415d7)</span></li>
<li>backends/xrandr/xrandr.cpp <span style="color: grey">(fae1dcc)</span></li>
<li>backends/xrandr1.1/xrandr11.cpp <span style="color: grey">(631bcc9)</span></li>
<li>src/debug_p.cpp <span style="color: grey">(5934417)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126630/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0989996732649947309==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic