[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125862: Add simple calendar events plugin based on KHolidays
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2016-03-28 19:54:26
Message-ID: 20160328195426.12706.9096 () mimi ! kde ! org
[Download RAW message or body]
--===============9179309642597649810==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 23, 2016, 2:09 p.m., David Edmundson wrote:
> > Martin, what is the state of this?
> >
> > You're in danger of missing Plasma 5.6.
>
> Martin Klapetek wrote:
> I very likely won't be able to finish it in this cycle.
>
> David Edmundson wrote:
> well, what's missing?
> I don't want to miss 5.7 too.
It's on my todo once I'm back from vacation.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review92660
-----------------------------------------------------------
On Nov. 18, 2015, 1:33 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 1:33 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
>
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
>
>
> Diffs
> -----
>
> CMakeLists.txt 4783a78
> plasmacalendarintegration/CMakeLists.txt PRE-CREATION
> plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION
> plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION
> plasmacalendarintegration/holidaysevents.h PRE-CREATION
> plasmacalendarintegration/holidaysevents.cpp PRE-CREATION
> plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION
> plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h PRE-CREATION
> plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp PRE-CREATION
> plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
>
>
> Testing
> -------
>
> Holidays are properly listed in calendar applet.
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============9179309642597649810==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125862/">https://git.reviewboard.kde.org/r/125862/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 23rd, 2016, 2:09 p.m. CET, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Martin, what is the state of this?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">You're in danger of missing Plasma 5.6.</p></pre> </blockquote>
<p>On February 23rd, 2016, 2:59 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
very likely won't be able to finish it in this cycle.</p></pre> </blockquote>
<p>On March 28th, 2016, 9:38 p.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">well, \
what's missing? I don't want to miss 5.7 too.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
on my todo once I'm back from vacation.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On November 18th, 2015, 1:33 a.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2015, 1:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is very simple for now as there is no \
configuration yet, so it just takes the default region (your locale)
and shows holidays from that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Obviously this needs a config to set up which regions \
you want to show in there, but this is a start.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Holidays are properly listed in calendar \
applet.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4783a78)</span></li>
<li>plasmacalendarintegration/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/HolidaysConfig.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/holidayeventsplugin.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/holidaysevents.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/holidaysevents.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/qmlhelper/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/qmlhelper/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125862/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9179309642597649810==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic