[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127492: KCM: Add possibility to move stream to other devices
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-03-25 13:55:35
Message-ID: 20160325135535.21226.90284 () mimi ! kde ! org
[Download RAW message or body]
--===============3036788788820489752==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On März 25, 2016, 1:41 nachm., Kai Uwe Broulik wrote:
> > While I like seeing this option return, especially with your other "Primary \
> > Device" patch makes this UI really cluttered.
> > What about having a drop down button with the device icon rather than the \
> > full-blown text in there? So you'll at least be able to tell at a glance "it's on \
> > my headset" or so
>
> David Rosca wrote:
> Primary Device is only for Devices, not Streams.
> Device icons are too generic (not to mention that currently every device have the \
> same icons, needs to be fixed). If you have more cards (eg. internal + usb) you \
> wouldn't be able to tell them apart, only headset will have different icon.
Ah, yeah, sorry. ComboBox it is then :) Oh how I wish the sizing in QQC wasn't \
broken, those three dots all over the place make me cry.
Excellent work on the PA thing!
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127492/#review93977
-----------------------------------------------------------
On März 25, 2016, 1:34 nachm., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127492/
> -----------------------------------------------------------
>
> (Updated März 25, 2016, 1:34 nachm.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-pa
>
>
> Description
> -------
>
> Add combobox next to mute button with available devices.
>
>
> Diffs
> -----
>
> src/kcm/package/contents/ui/SinkInputView.qml PRE-CREATION
> src/kcm/package/contents/ui/SourceOutputView.qml PRE-CREATION
> src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e
> src/kcm/package/contents/ui/StreamView.qml b08c87a
> src/kcm/package/contents/ui/main.qml 3360201
>
> Diff: https://git.reviewboard.kde.org/r/127492/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot_20160325_142736.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/25/06b2aafd-f05d-4140-933a-89fbc8ed7c5c__Screenshot_20160325_142736.png
>
>
> Thanks,
>
> David Rosca
>
>
--===============3036788788820489752==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127492/">https://git.reviewboard.kde.org/r/127492/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On März 25th, 2016, 1:41 nachm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While I like seeing this option return, especially \
with your other "Primary Device" patch makes this UI really cluttered.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What about having a drop down button with the device icon rather than the \
full-blown text in there? So you'll at least be able to tell at a glance "it's on my \
headset" or so</p></pre> </blockquote>
<p>On März 25th, 2016, 1:45 nachm. UTC, <b>David Rosca</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Primary Device is only for Devices, not Streams. Device icons are too \
generic (not to mention that currently every device have the same icons, needs to be \
fixed). If you have more cards (eg. internal + usb) you wouldn't be able to tell them \
apart, only headset will have different icon.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, \
yeah, sorry. ComboBox it is then :) Oh how I wish the sizing in QQC wasn't broken, \
those three dots all over the place make me cry.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Excellent work on the PA thing!</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On März 25th, 2016, 1:34 nachm. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated März 25, 2016, 1:34 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add combobox next to mute button with available \
devices.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcm/package/contents/ui/SinkInputView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/kcm/package/contents/ui/SourceOutputView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/kcm/package/contents/ui/StreamListItem.qml <span style="color: \
grey">(7f1d69e)</span></li>
<li>src/kcm/package/contents/ui/StreamView.qml <span style="color: \
grey">(b08c87a)</span></li>
<li>src/kcm/package/contents/ui/main.qml <span style="color: \
grey">(3360201)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127492/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/25/06b2aafd \
-f05d-4140-933a-89fbc8ed7c5c__Screenshot_20160325_142736.png">Screenshot_20160325_142736.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3036788788820489752==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic