[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127485: KCM: Add button to set default devices
From: David Rosca <nowrep () gmail ! com>
Date: 2016-03-24 21:42:17
Message-ID: 20160324214217.21226.44340 () mimi ! kde ! org
[Download RAW message or body]
--===============0163305200263636745==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote:
> > I like the RadioButton but it should say "Default" or "Default Device" (if we \
> > could depend on Qt 5.7 we could also add a tooltip explaining what that means... \
> > :/ )
> > Can you perhaps also have a look at the OSD/volume keys to affect the default \
> > device? At the moment it's kinda random what device it actually shows and \
> > manipulates all of them simultaneously etc
> I like the RadioButton but it should say "Default" or "Default Device" (if we could \
> depend on Qt 5.7 we could also add a tooltip explaining what that means... :/ )
What about:
`text: checked ? "Default" : ""`
> Can you perhaps also have a look at the OSD/volume keys to affect the default \
> device? At the moment it's kinda random what device it actually shows and \
> manipulates all of them simultaneously etc
Yes, in next patch.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127485/#review93950
-----------------------------------------------------------
On March 24, 2016, 9:08 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127485/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 9:08 p.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-pa
>
>
> Description
> -------
>
> It is now possible to set default input and output devices.
> UI is exactly the same as pavucontrol - checkable button next to mute button.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt b3e1855
> src/context.h 8a3a821
> src/context.cpp 115c8a7
> src/device.h 5867fb2
> src/kcm/package/contents/ui/DefaultDeviceButton.qml PRE-CREATION
> src/kcm/package/contents/ui/DeviceListItem.qml 979c693
> src/server.h PRE-CREATION
> src/server.cpp PRE-CREATION
> src/sink.h 7db716b
> src/sink.cpp d412b7b
> src/source.h 325cde9
> src/source.cpp fa9f0a0
>
> Diff: https://git.reviewboard.kde.org/r/127485/diff/
>
>
> Testing
> -------
>
> Works same as pavucontrol. pavucontrol uses "emblem-default" as icon, but this icon \
> is not in Breeze so I used "checkmark". Unfortunately it isn't entirely clear what \
> the button is doing from the icon ...
>
> File Attachments
> ----------------
>
> kcm-default-device.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/6d5d5bb5-3619-470c-b6d6-e7693d888c9b__kcm-default-device.png
> kcm-default-device.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/23f3638a-aa27-4f46-aa6a-989c8d313a6a__Screenshot_20160324_220624.png
>
>
> Thanks,
>
> David Rosca
>
>
--===============0163305200263636745==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127485/">https://git.reviewboard.kde.org/r/127485/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 24th, 2016, 9:37 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I like the RadioButton but it should say "Default" or \
"Default Device" (if we could depend on Qt 5.7 we could also add a tooltip explaining \
what that means... :/ )</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Can you perhaps also have a look at the \
OSD/volume keys to affect the default device? At the moment it's kinda random what \
device it actually shows and manipulates all of them simultaneously etc</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I like the RadioButton but it should say "Default" or "Default Device" (if \
we could depend on Qt 5.7 we could also add a tooltip explaining what that means... \
:/ )</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What about: <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">text: checked ? "Default" : ""</code></p> <blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Can you perhaps also have a look at the OSD/volume keys to affect the \
default device? At the moment it's kinda random what device it actually shows and \
manipulates all of them simultaneously etc</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes, in next patch.</p></pre> <br />
<p>- David</p>
<br />
<p>On March 24th, 2016, 9:08 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 24, 2016, 9:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It is now possible to set default input and output \
devices. UI is exactly the same as pavucontrol - checkable button next to mute \
button.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works same as pavucontrol. pavucontrol uses \
"emblem-default" as icon, but this icon is not in Breeze so I used "checkmark". \
Unfortunately it isn't entirely clear what the button is doing from the icon \
...</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(b3e1855)</span></li>
<li>src/context.h <span style="color: grey">(8a3a821)</span></li>
<li>src/context.cpp <span style="color: grey">(115c8a7)</span></li>
<li>src/device.h <span style="color: grey">(5867fb2)</span></li>
<li>src/kcm/package/contents/ui/DefaultDeviceButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/kcm/package/contents/ui/DeviceListItem.qml <span style="color: \
grey">(979c693)</span></li>
<li>src/server.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/sink.h <span style="color: grey">(7db716b)</span></li>
<li>src/sink.cpp <span style="color: grey">(d412b7b)</span></li>
<li>src/source.h <span style="color: grey">(325cde9)</span></li>
<li>src/source.cpp <span style="color: grey">(fa9f0a0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127485/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/6d5d5bb5 \
-3619-470c-b6d6-e7693d888c9b__kcm-default-device.png">kcm-default-device.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/23f3638a \
-aa27-4f46-aa6a-989c8d313a6a__Screenshot_20160324_220624.png">kcm-default-device.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0163305200263636745==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic