'Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups
From:       Hugo Pereira Da Costa <hugo.pereira () free ! fr>
Date:       2016-03-22 15:11:32
Message-ID: 20160322151132.21226.9127 () mimi ! kde ! org
[Download RAW message or body]

--===============1133648352061863114==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/#review93869
-----------------------------------------------------------

Ship it!

Ship It!

- Hugo Pereira Da Costa

On March 22, 2016, 3:05 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127460/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 3:05 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Bugs: 343369
> https://bugs.kde.org/show_bug.cgi?id=343369
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
> Also expand CT_ItemViewItem size for QtQuickControls too.
> 
> BUG: 343369
> 
> 
> Diffs
> -----
> 
> kstyle/breezestyle.cpp 9a4b674 
> 
> Diff: https://git.reviewboard.kde.org/r/127460/diff/
> 
> 
> Testing
> -------
> 
> QtQuickControls ComboBox popups now use palette colors and have correct spacing.
> 
> 
> File Attachments
> ----------------
> 
> popup-light.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
>  popup-dark.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png
>  
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============1133648352061863114==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127460/">https://git.reviewboard.kde.org/r/127460/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Hugo Pereira Da Costa</p>

<br />
<p>On March 22nd, 2016, 3:05 p.m. UTC, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated March 22, 2016, 3:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=343369">343369</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Implement drawing QStyleOptionFrame \
QFrame::StyledPanel shape. Also expand CT_ItemViewItem size for QtQuickControls \
too.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 343369</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QtQuickControls ComboBox popups now use palette colors \
and have correct spacing.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstyle/breezestyle.cpp <span style="color: grey">(9a4b674)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127460/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png">popup-light.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png">popup-dark.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1133648352061863114==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 