[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-03-21 21:25:25
Message-ID: 20160321212525.21226.19287 () mimi ! kde ! org
[Download RAW message or body]
--===============6764635084436502801==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127455/#review93841
-----------------------------------------------------------
src/declarativeimports/calendar/qml/MonthView.qml (lines 36 - 37)
<https://git.reviewboard.kde.org/r/127455/#comment63938>
While I agree, this property is stupid, it would break our API-compatibility \
promise.
- Kai Uwe Broulik
On März 21, 2016, 9:11 nachm., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127455/
> -----------------------------------------------------------
>
> (Updated März 21, 2016, 9:11 nachm.)
>
>
> Review request for Plasma.
>
>
> Bugs: 360683
> http://bugs.kde.org/show_bug.cgi?id=360683
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This removes some old cruft that is not really used and serves
> basically only as a bool property for checking if it's null and
> wheter it equals the last activated date.
>
> This can be done without it by simply resetting the current selected
> date (another property) to "today".
>
> I decided to leave the useless property in for the time being
> to allow for some buffer time between the -workspace and -framework
> release so that it does not throw errors (ie. if distros will
> ship 5.6 + p-f 5.21).
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/qml/DayDelegate.qml 6877150
> src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f
> src/declarativeimports/calendar/qml/MonthView.qml 76c605a
>
> Diff: https://git.reviewboard.kde.org/r/127455/diff/
>
>
> Testing
> -------
>
> Selection is properly cleared.
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============6764635084436502801==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127455/">https://git.reviewboard.kde.org/r/127455/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127455/diff/1/?file=453733#file453733line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/calendar/qml/MonthView.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//FIXME remove this for 5.7</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">36</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="nx">QtObject</span> <span \
class="nx">date</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">37</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="nx">property</span> <span \
class="nx">QtObject</span> <span class="nx">date</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While \
I agree, this property is stupid, it would break our API-compatibility \
promise.</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On März 21st, 2016, 9:11 nachm. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated März 21, 2016, 9:11 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=360683">360683</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This removes some old cruft that is not really used \
and serves basically only as a bool property for checking if it's null and
wheter it equals the last activated date.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This can be done without it by simply resetting the \
current selected date (another property) to "today".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I decided to leave the useless property in for the \
time being to allow for some buffer time between the -workspace and -framework
release so that it does not throw errors (ie. if distros will
ship 5.6 + p-f 5.21).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Selection is properly cleared.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/qml/DayDelegate.qml <span style="color: \
grey">(6877150)</span></li>
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(8248a8f)</span></li>
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(76c605a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127455/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6764635084436502801==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic