[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127390: [kstyle] Implement window shadows on Wayland
From: Hugo Pereira Da Costa <hugo.pereira () free ! fr>
Date: 2016-03-16 9:55:52
Message-ID: 20160316095552.6030.38647 () mimi ! kde ! org
[Download RAW message or body]
--===============8302041957005791909==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127390/#review93590
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Pereira Da Costa
On March 16, 2016, 8:49 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127390/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 8:49 a.m.)
>
>
> Review request for Plasma and Hugo Pereira Da Costa.
>
>
> Repository: oxygen
>
>
> Description
> -------
>
> Integrate with Wayland and create a ShadowManager if available.
> With the ShadowManager it's possible to create a Shadow for a Surface.
>
> The Wayland shadow is very similar to the X11 based one, so a lot of
> code can be shared. The code is slightly refactored to share the common
> code paths to create and destroy the shadow.
>
>
> Diffs
> -----
>
> CMakeLists.txt 18cd7509d874da68221bdddb7218e59064ad9834
> kstyle/CMakeLists.txt faf7e97ec07910d9277256d4cd68023e27e4abe5
> kstyle/oxygenshadowhelper.h ff026f3e4605c599127418fa1c7d865203440953
> kstyle/oxygenshadowhelper.cpp 91ba90bd8e5c9dcf773a6a44636699e4c7d634ff
> liboxygen/config-liboxygen.h.cmake ad91f8c3a8c4cf5619387b14e4ccfae557aa3578
>
> Diff: https://git.reviewboard.kde.org/r/127390/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Spectacle.X21508.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/16/9c1b6dcb-da34-4a83-8900-f3c0d2534855__Spectacle.X21508.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============8302041957005791909==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127390/">https://git.reviewboard.kde.org/r/127390/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Hugo Pereira Da Costa</p>
<br />
<p>On March 16th, 2016, 8:49 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 16, 2016, 8:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
oxygen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Integrate with Wayland and create a ShadowManager if available. With the \
ShadowManager it's possible to create a Shadow for a Surface.
The Wayland shadow is very similar to the X11 based one, so a lot of
code can be shared. The code is slightly refactored to share the common
code paths to create and destroy the shadow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(18cd7509d874da68221bdddb7218e59064ad9834)</span></li>
<li>kstyle/CMakeLists.txt <span style="color: \
grey">(faf7e97ec07910d9277256d4cd68023e27e4abe5)</span></li>
<li>kstyle/oxygenshadowhelper.h <span style="color: \
grey">(ff026f3e4605c599127418fa1c7d865203440953)</span></li>
<li>kstyle/oxygenshadowhelper.cpp <span style="color: \
grey">(91ba90bd8e5c9dcf773a6a44636699e4c7d634ff)</span></li>
<li>liboxygen/config-liboxygen.h.cmake <span style="color: \
grey">(ad91f8c3a8c4cf5619387b14e4ccfae557aa3578)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127390/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/16/9c1b6dcb \
-da34-4a83-8900-f3c0d2534855__Spectacle.X21508.png">Spectacle.X21508.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8302041957005791909==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic