[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell
From: Aleix Pol Gonzalez <aleixpol () kde ! org>
Date: 2016-03-10 15:37:00
Message-ID: 20160310153700.22760.17610 () mimi ! kde ! org
[Download RAW message or body]
--===============1035472761745369012==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 10, 2016, 3 p.m., Marco Martin wrote:
> > Ship It!
Heh, hold your horses (my horses?). Still uses Qt 5.6 and doesn't have the changes we \
discussed.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review93388
-----------------------------------------------------------
On March 10, 2016, 11:48 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 11:48 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Now that everything's in place in Qt, we can do that.
>
> It basically removes all the translation layer between KScreen and QScreen.
>
> NOTE: This can't be merged until Qt 5.6 is a dependency.
>
>
> Diffs
> -----
>
> CMakeLists.txt d407aed
> shell/CMakeLists.txt 7be2cfd
> shell/panelview.h c671f14
> shell/panelview.cpp c8c3c71
> shell/shellcorona.h b803239
> shell/shellcorona.cpp 54667da
>
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
>
>
> Testing
> -------
>
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There \
> could be crashes, I just didn't find them :D)
>
> File Attachments
> ----------------
>
> org.kde.konversation.desktop
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/01/47534796-9ab4-4f8f-b770-089cae126b84__org.kde.konversation.desktop
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============1035472761745369012==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125451/">https://git.reviewboard.kde.org/r/125451/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 10th, 2016, 3 p.m. CET, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Heh, \
hold your horses (my horses?). Still uses Qt 5.6 and doesn't have the changes we \
discussed.</p></pre> <br />
<p>- Aleix</p>
<br />
<p>On March 10th, 2016, 11:48 a.m. CET, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 10, 2016, 11:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now that everything's in place in Qt, we can do \
that.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It basically removes all the translation layer between \
KScreen and QScreen.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">NOTE: This can't be merged until Qt 5.6 \
is a dependency.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hands-on testing, it's been working quite fluid and I \
couldn't find a crash. (There could be crashes, I just didn't find them :D)</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d407aed)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(7be2cfd)</span></li>
<li>shell/panelview.h <span style="color: grey">(c671f14)</span></li>
<li>shell/panelview.cpp <span style="color: grey">(c8c3c71)</span></li>
<li>shell/shellcorona.h <span style="color: grey">(b803239)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(54667da)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125451/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/01/47534796 \
-9ab4-4f8f-b770-089cae126b84__org.kde.konversation.desktop">org.kde.konversation.desktop</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1035472761745369012==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic