[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127260: Experiment: cache svg icons from icon theme
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-03-04 20:52:20
Message-ID: 20160304205220.32153.56919 () mimi ! kde ! org
[Download RAW message or body]

--===============6479393707372920468==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/#review93174
-----------------------------------------------------------



Given how many troubles we've had (and still have) with caches I'd love to see a \
thorough auto unit test before merging.

It seems a bit odd to share the cache file with the plasma theme SVG cache given the \
source is different. 

I have a feeling that you'll discard the cache, then immediately load the same \
KImageCache file and as the name (which is based on plasma theme number) hasn't \
changed just reload the same old thing again.


src/plasma/private/theme_p.cpp (line 231)
<https://git.reviewboard.kde.org/r/127260/#comment63527>

    can you rely on the metadatafile being touched if icons update?
    
    For .deb packages it's fine, but with delta RPMs, I'm not sure if it's true?



src/plasma/private/theme_p.cpp (line 233)
<https://git.reviewboard.kde.org/r/127260/#comment63528>

    I'm not sure this works.
    This compares if the cache file > icon file.
    
    This is a shared cache; both in terms of a file and mmapd memory.
    so what happens when you run krunner and plasmashell at the same time when you \
upgrade and you change icons -  one will update, the other won't.


- David Edmundson


On March 4, 2016, 11:04 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127260/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 11:04 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this attempts to cache as well svg icons from the icon theme (invalidating as well \
> when the icon theme is updated) 
> still to be done, to figure out to invalidate cache when the icon theme is changed \
>                 in the two cases:
> * theme changed with plasmashell running
> * theme changed with plasma shell not running
> 
> 
> Diffs
> -----
> 
> src/plasma/private/theme_p.h 69a8934 
> src/plasma/private/theme_p.cpp 943d3af 
> src/plasma/svg.cpp ccd248a 
> 
> Diff: https://git.reviewboard.kde.org/r/127260/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 


--===============6479393707372920468==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127260/">https://git.reviewboard.kde.org/r/127260/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Given \
how many troubles we've had (and still have) with caches I'd love to see a thorough \
auto unit test before merging.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems a bit odd to \
share the cache file with the plasma theme SVG cache given the source is different. \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have a feeling that you'll discard the cache, then \
immediately load the same KImageCache file and as the name (which is based on plasma \
theme number) hasn't changed just reload the same old thing again.</p></pre>  <br />







<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/127260/diff/2/?file=447948#file447948line231" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasma/private/theme_p.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">223</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span \
class="n">cachesTooOld</span> <span class="o">=</span> <span \
class="n">cacheFileInfo</span><span class="p">.</span><span \
class="n">lastModified</span><span class="p">().</span><span \
class="n">toTime_t</span><span class="p">()</span> <span class="o">&lt;</span> <span \
class="n">metadataFileInfo</span><span class="p">.</span><span \
class="n">lastModified</span><span class="p">().</span><span \
class="n">toTime_t</span><span class="p">();</span></pre></td>  <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">231</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span \
class="k">const</span> <span class="n">QFileInfo</span> <span \
class="nf">iconThemeMetadataFileInfo</span><span class="p">(</span><span \
class="n">iconThemeMetadataPath</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can \
you rely on the metadatafile being touched if icons update?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
.deb packages it's fine, but with delta RPMs, I'm not sure if it's true?</p></pre>  \
</div> </div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/127260/diff/2/?file=447948#file447948line233" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasma/private/theme_p.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">233</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">cachesTooOld</span> <span class="o">=</span> <span \
class="p">(</span><span class="n">cacheFileInfo</span><span class="p">.</span><span \
class="n">lastModified</span><span class="p">().</span><span \
class="n">toTime_t</span><span class="p">()</span> <span class="o">&lt;</span> <span \
class="n">metadataFileInfo</span><span class="p">.</span><span \
class="n">lastModified</span><span class="p">().</span><span \
class="n">toTime_t</span><span class="p">())</span> <span \
class="o">||</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not sure this works. This compares if the cache file &gt; icon file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a shared cache; both in terms of a file and \
mmapd memory. so what happens when you run krunner and plasmashell at the same time \
when you upgrade and you change icons -  one will update, the other won't.</p></pre>  \
</div> </div>
<br />



<p>- David Edmundson</p>


<br />
<p>On March 4th, 2016, 11:04 a.m. UTC, Marco Martin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>


<p style="color: grey;"><i>Updated March 4, 2016, 11:04 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this attempts to cache as well svg icons from the icon \
theme (invalidating as well when the icon theme is updated)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">still \
to be done, to figure out to invalidate cache when the icon theme is changed in the \
two cases: <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> theme changed with plasmashell running </em> theme \
changed with plasma shell not running</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasma/private/theme_p.h <span style="color: grey">(69a8934)</span></li>

 <li>src/plasma/private/theme_p.cpp <span style="color: grey">(943d3af)</span></li>

 <li>src/plasma/svg.cpp <span style="color: grey">(ccd248a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127260/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============6479393707372920468==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic