'Re: Review Request 127260: Experiment: cache svg icons from icon theme'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127260: Experiment: cache svg icons from icon theme
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-03-03 12:27:21
Message-ID: 20160303122721.32153.97126 () mimi ! kde ! org
[Download RAW message or body]

--===============2189416898063933821==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On March 2, 2016, 11:48 p.m., David Edmundson wrote:
> > why would someone load an icon as an SVG and not use IconItem?
> 
> Marco Martin wrote:
> there is somebody loading icons as SVG and not using IconItem and it is wait for \
> it... IconItem :p jokes aside, i think this should be done at the lowest level this \
> things happen, no?

Oh the new
                //try to load from iconloader an svg with Plasma::Svg

path
OK, that makes sense.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/#review93079
-----------------------------------------------------------

On March 2, 2016, 3:44 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127260/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 3:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this attempts to cache as well svg icons from the icon theme (invalidating as well \
> when the icon theme is updated) 
> still to be done, to figure out to invalidate cache when the icon theme is changed \
>                 in the two cases:
> * theme changed with plasmashell running
> * theme changed with plasma shell not running
> 
> 
> Diffs
> -----
> 
> src/plasma/private/theme_p.h 69a8934 
> src/plasma/private/theme_p.cpp 943d3af 
> src/plasma/svg.cpp ccd248a 
> 
> Diff: https://git.reviewboard.kde.org/r/127260/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============2189416898063933821==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127260/">https://git.reviewboard.kde.org/r/127260/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 2nd, 2016, 11:48 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">why would someone load an icon as an SVG and not use \
IconItem?</p></pre>  </blockquote>

 <p>On March 3rd, 2016, 10:39 a.m. UTC, <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there \
is somebody loading icons as SVG and not using IconItem and it is wait for it... \
IconItem :p jokes aside, i think this should be done at the lowest level this things \
happen, no?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh \
the new  //try to load from iconloader an svg with Plasma::Svg</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">path OK, that makes sense.</p></pre>
<br />

<p>- David</p>

<br />
<p>On March 2nd, 2016, 3:44 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated March 2, 2016, 3:44 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this attempts to cache as well svg icons from the icon \
theme (invalidating as well when the icon theme is updated)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">still \
to be done, to figure out to invalidate cache when the icon theme is changed in the \
two cases: <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> theme changed with plasmashell running </em> theme \
changed with plasma shell not running</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasma/private/theme_p.h <span style="color: grey">(69a8934)</span></li>

 <li>src/plasma/private/theme_p.cpp <span style="color: grey">(943d3af)</span></li>

 <li>src/plasma/svg.cpp <span style="color: grey">(ccd248a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127260/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2189416898063933821==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 