'Re: Review Request 127229: Workaround bug 352055'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127229: Workaround bug 352055
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-03-01 14:23:52
Message-ID: 20160301142352.32153.42308 () mimi ! kde ! org
[Download RAW message or body]

--===============7534783234819812227==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On March 1, 2016, 8:45 a.m., Marco Martin wrote:
> > Yeah, either this or changing systray for 5.6 already :/
> > and i think it's an issue in Qml, since it's very old code and this problem \
> > really started only on 5.6 branch of Qt

This problem did not only start on the 5.6 branch of Qt. You should know that, the \
bug history goes back since forever.

It's a timing/race situation. Each change makes it work for some people and makes it \
appear for others.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127229/#review92970
-----------------------------------------------------------

On Feb. 29, 2016, 10:16 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127229/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 10:16 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 352055
> https://bugs.kde.org/show_bug.cgi?id=352055
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> From my debug, the real problem is that the model value in qml some times can have \
> wrong value. When there is the "empty" space in systray, model.index obtained from \
> delegate is -1 and no any other data is available, which should never happens. 
> This is obviously a bug in Qt.. but unfortunately I have no simple test case to \
> reproduce it. 
> 
> Diffs
> -----
> 
> applets/systemtray/plugin/tasklistmodel.cpp 1fa306c 
> 
> Diff: https://git.reviewboard.kde.org/r/127229/diff/
> 
> 
> Testing
> -------
> 
> Works for me at least.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
> 

--===============7534783234819812227==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127229/">https://git.reviewboard.kde.org/r/127229/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 1st, 2016, 8:45 a.m. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yeah, either this or changing systray for 5.6 already \
:/ and i think it's an issue in Qml, since it's very old code and this problem really \
started only on 5.6 branch of Qt</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
problem did not only start on the 5.6 branch of Qt. You should know that, the bug \
history goes back since forever.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It's a timing/race \
situation. Each change makes it work for some people and makes it appear for \
others.</p></pre> <br />

<p>- David</p>

<br />
<p>On February 29th, 2016, 10:16 p.m. UTC, Xuetian Weng wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Feb. 29, 2016, 10:16 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=352055">352055</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">From my debug, the real problem is that the model \
value in qml some times can have wrong value. When there is the "empty" space in \
systray, model.index obtained from delegate is -1 and no any other data is available, \
which should never happens.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This is obviously a bug in Qt.. but \
unfortunately I have no simple test case to reproduce it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works for me at least.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemtray/plugin/tasklistmodel.cpp <span style="color: \
grey">(1fa306c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127229/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7534783234819812227==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 