'Re: Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell
From:       Xuetian Weng <wengxt () gmail ! com>
Date:       2016-02-29 22:17:40
Message-ID: 20160229221740.32153.33120 () mimi ! kde ! org
[Download RAW message or body]

--===============0198493329077896814==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127227/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 10:17 p.m.)

Status
------

This change has been discarded.

Review request for Plasma and David Edmundson.

Repository: plasma-workspace

Description
-------

Qt 5.6 introduces 3 new env variable for control high dpi scaling. unset them just \
like QT_DEVICE_PIXEL_RATIO.

Diffs
-----

  shell/main.cpp d9963aa 

Diff: https://git.reviewboard.kde.org/r/127227/diff/

Testing
-------

On 5.6.0RC, I get some strange font size in plasmashell with it set, and quite a lot \
of size is not correct. Attach some screenshot for a idea. Looks like we are not \
ready for it yet.

File Attachments
----------------

Screenshot_20160229_134832.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/29/b7cda20b-fe0c-4bd8-a674-54d87bc5ccdf__Screenshot_20160229_134832.png
 Screenshot_20160229_134846.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/29/4116c15c-393a-4885-bef9-78c9ab92ab37__Screenshot_20160229_134846.png

Thanks,

Xuetian Weng

--===============0198493329077896814==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127227/">https://git.reviewboard.kde.org/r/127227/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Feb. 29, 2016, 10:17 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Qt 5.6 introduces 3 new env variable for control high \
dpi scaling. unset them just like QT_DEVICE_PIXEL_RATIO.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On 5.6.0RC, I get some strange font size in \
plasmashell with it set, and quite a lot of size is not correct. Attach some \
screenshot for a idea. Looks like we are not ready for it yet.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/main.cpp <span style="color: grey">(d9963aa)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127227/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/29/b7cda20b \
-fe0c-4bd8-a674-54d87bc5ccdf__Screenshot_20160229_134832.png">Screenshot_20160229_134832.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/29/4116c15c \
-393a-4885-bef9-78c9ab92ab37__Screenshot_20160229_134846.png">Screenshot_20160229_134846.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0198493329077896814==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 