--===============2257913158331249409== Content-Type: multipart/alternative; boundary="===============8752096377586804403==" --===============8752096377586804403== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ ----------------------------------------------------------- (Updated Feb. 29, 2016, 11:05 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin. Changes ------- Submitted with commit 066cf0a0d7b46c60fccb945dbc0e9f858c4d6967 by Weng Xuetian to branch master. Repository: plasma-framework Description ------- Well.. the bug should be obvious: 1. QString iconPath overrides the iconPath in a higher scope. introduced in https://git.reviewboard.kde.org/r/126168/ 2. iconPath not assigned, also introduced in https://git.reviewboard.kde.org/r/126168/ 3. svgz -> svg?? introduced in https://git.reviewboard.kde.org/r/126557/ Diffs ----- autotests/data/bug359388/hicolor/22x22/apps/bug359388.svg PRE-CREATION autotests/data/icons/hicolor/22x22/apps/bug359388.svg 8739af5 autotests/data/icons/test-theme/apps/22/tst-plasma-framework-test-icon.svg PRE-CREATION autotests/data/icons/test-theme/apps/32/tst-plasma-framework-test-icon.svg PRE-CREATION autotests/data/icons/test-theme/apps/48/konversation.svg PRE-CREATION autotests/data/icons/test-theme/index.theme PRE-CREATION autotests/iconitemtest.h 9fd3063 autotests/iconitemtest.cpp ea98c9d src/declarativeimports/core/iconitem.cpp c65a9a7 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing ------- tested with qmlscene with Plasma.IconItem. Thanks, Xuetian Weng --===============8752096377586804403== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/

This change has been marked as submitted.

Review request for KDE Frameworks, Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin.
By Xuetian Weng.

Updated Feb. 29, 2016, 11:05 p.m.

Changes

Submitted with commit 066cf0a0d7b46c60fccb945dbc0e9f858c4d6967 by Weng Xuetian to branch master.
Repository: plasma-framework

Description 

Well.. the bug should be obvious:
1. QString iconPath overrides the iconPath in a higher scope. introduced in https://git.reviewboard.kde.org/r/126168/
2. iconPath not assigned, also introduced in https://git.reviewboard.kde.org/r/126168/
3. svgz -> svg?? introduced in https://git.reviewboard.kde.org/r/126557/

Testing 

tested with qmlscene with Plasma.IconItem.

Diffs

  • autotests/data/bug359388/hicolor/22x22/apps/bug359388.svg (PRE-CREATION)
  • autotests/data/icons/hicolor/22x22/apps/bug359388.svg (8739af5)
  • autotests/data/icons/test-theme/apps/22/tst-plasma-framework-test-icon.svg (PRE-CREATION)
  • autotests/data/icons/test-theme/apps/32/tst-plasma-framework-test-icon.svg (PRE-CREATION)
  • autotests/data/icons/test-theme/apps/48/konversation.svg (PRE-CREATION)
  • autotests/data/icons/test-theme/index.theme (PRE-CREATION)
  • autotests/iconitemtest.h (9fd3063)
  • autotests/iconitemtest.cpp (ea98c9d)
  • src/declarativeimports/core/iconitem.cpp (c65a9a7)

View Diff
--===============8752096377586804403==-- --===============2257913158331249409== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2257913158331249409==--